-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native-filters): add null option to value filter #15419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #15419 +/- ##
==========================================
- Coverage 77.22% 76.97% -0.26%
==========================================
Files 975 974 -1
Lines 50634 50816 +182
Branches 6222 6727 +505
==========================================
+ Hits 39104 39117 +13
- Misses 11319 11484 +165
- Partials 211 215 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* fix: add null var to native filter (apache#15291) * small fix * refactoring code * restructure the JS code * update testcase
* fix: add null var to native filter (apache#15291) * small fix * refactoring code * restructure the JS code * update testcase
* fix: add null var to native filter (apache#15291) * small fix * refactoring code * restructure the JS code * update testcase
SUMMARY
This PR add option of "null" for the select filter in the Dashboard's Native Filter.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
"DASHBOARD_NATIVE_FILTERS": True
insuperset/config.py
publisher
ADDITIONAL INFORMATION