-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(feature_flags configurations): remove defaults values #15425
refactor(feature_flags configurations): remove defaults values #15425
Conversation
…onfiguration for default vales
Codecov Report
@@ Coverage Diff @@
## master #15425 +/- ##
==========================================
- Coverage 77.23% 76.98% -0.26%
==========================================
Files 975 975
Lines 50653 50651 -2
Branches 6223 6223
==========================================
- Hits 39124 38994 -130
- Misses 11318 11446 +128
Partials 211 211
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
straight forward refactor 🚀
…tional configuration for default vales (apache#15425)" This reverts commit 486b8d9.
…onfiguration for default vales (apache#15425)
…tional configuration for default vales (apache#15425)" (apache#15448)
…onfiguration for default vales (apache#15425)
…tional configuration for default vales (apache#15425)" (apache#15448)
…onfiguration for default vales (apache#15425)
…tional configuration for default vales (apache#15425)" (apache#15448)
SUMMARY
Due to #15405 default values are redundant since partial dictionary can be merged to original dictionary
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION