Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(feature_flags configurations): remove defaults values #15425

Merged

Conversation

ofekisr
Copy link
Contributor

@ofekisr ofekisr commented Jun 28, 2021

SUMMARY

Due to #15405 default values are redundant since partial dictionary can be merged to original dictionary

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #15425 (93c1dda) into master (d8a1acf) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

❗ Current head 93c1dda differs from pull request most recent head 4cbc7d2. Consider uploading reports for the commit 4cbc7d2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15425      +/-   ##
==========================================
- Coverage   77.23%   76.98%   -0.26%     
==========================================
  Files         975      975              
  Lines       50653    50651       -2     
  Branches     6223     6223              
==========================================
- Hits        39124    38994     -130     
- Misses      11318    11446     +128     
  Partials      211      211              
Flag Coverage Δ
hive ?
mysql 81.73% <100.00%> (-0.01%) ⬇️
postgres 81.75% <100.00%> (-0.01%) ⬇️
presto ?
python 81.80% <100.00%> (-0.49%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/cli.py 51.47% <100.00%> (ø)
superset/config.py 97.02% <100.00%> (-0.02%) ⬇️
superset/utils/feature_flag_manager.py 95.00% <100.00%> (-0.24%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.20% <0.00%> (-17.21%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.95%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/connectors/sqla/models.py 87.98% <0.00%> (-1.89%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a1acf...4cbc7d2. Read the comment docs.

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight forward refactor 🚀

@amitmiran137 amitmiran137 merged commit 486b8d9 into apache:master Jun 28, 2021
@amitmiran137 amitmiran137 deleted the refactor/feature_flags_configurations branch June 28, 2021 13:30
villebro added a commit to preset-io/superset that referenced this pull request Jun 29, 2021
…tional configuration for default vales (apache#15425)"

This reverts commit 486b8d9.
villebro added a commit that referenced this pull request Jun 29, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants