Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select item when allowNewOptions is true and Enter is pressed #15429

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Follow up of #15363.
Fixes the bug: When allowNewOptions is true and Enter is pressed, the item is not being selected.

@rusackas @geido

TESTING INSTRUCTIONS

1 - Open the Select storybook
2 - Go to "Interactive Select"
3 - Enable allowNewOptions
4 - Type an unknown value and press Enter
5 - The value should be created and checked

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added this to In progress in AntD Transition (SIP-48) via automation Jun 28, 2021
AntD Transition (SIP-48) automation moved this from In progress to In review Jun 28, 2021
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #15429 (cf721de) into master (d8a1acf) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15429      +/-   ##
==========================================
- Coverage   77.23%   77.22%   -0.02%     
==========================================
  Files         975      975              
  Lines       50653    50659       +6     
  Branches     6223     6228       +5     
==========================================
- Hits        39124    39121       -3     
- Misses      11318    11327       +9     
  Partials      211      211              
Flag Coverage Δ
javascript 71.70% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
...rBar/CascadeFilters/CascadeFilterControl/index.tsx 90.00% <0.00%> (-2.31%) ⬇️
...Filters/FilterBar/FilterControls/FilterControl.tsx 100.00% <0.00%> (ø)
.../FilterBar/CascadeFilters/CascadePopover/index.tsx 62.31% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a1acf...cf721de. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 0b7e524 into apache:master Jun 28, 2021
AntD Transition (SIP-48) automation moved this from In review to Done Jun 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants