Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better Errors in SQL Lab #15432

Merged
merged 7 commits into from Jun 29, 2021

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Jun 28, 2021

SUMMARY

Added Syntax, Column, Table, and Schema errors for Big Query and Snowflake. Then updated most often used databases to have syntax errors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
Screen Shot 2021-06-28 at 5 44 33 PM
Screen Shot 2021-06-29 at 11 41 32 AM

Big Query:
Screen Shot 2021-06-28 at 4 16 36 PM
Screen Shot 2021-06-28 at 4 26 11 PM
Screen Shot 2021-06-28 at 4 30 28 PM
Screen Shot 2021-06-29 at 10 58 59 AM

Postgres:
Screen Shot 2021-06-29 at 2 12 12 PM

Syntax Errors:
Screen Shot 2021-06-29 at 2 12 12 PM

Screen Shot 2021-06-29 at 5 34 50 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi changed the title feat: added snowflake specific errors to SQL Lab feat: Big Query and Snowflake SQL Lab errors Jun 28, 2021
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 28, 2021
@AAfghahi AAfghahi marked this pull request as ready for review June 29, 2021 15:48
@AAfghahi AAfghahi force-pushed the ch17980_dbSpecificErrors branch 3 times, most recently from 9825f4b to 9b555bb Compare June 29, 2021 16:06
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #15432 (67988e7) into master (ab7f31f) will increase coverage by 0.00%.
The diff coverage is 93.10%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15432   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         974      974           
  Lines       50701    50773   +72     
  Branches     6239     6256   +17     
=======================================
+ Hits        39126    39182   +56     
- Misses      11362    11378   +16     
  Partials      213      213           
Flag Coverage Δ
hive 81.47% <100.00%> (+0.01%) ⬆️
javascript 71.77% <0.00%> (-0.02%) ⬇️
mysql 81.73% <100.00%> (+0.01%) ⬆️
postgres 81.75% <100.00%> (+0.01%) ⬆️
python 82.13% <100.00%> (+0.01%) ⬆️
sqlite 81.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)
superset/db_engine_specs/athena.py 89.28% <100.00%> (+2.32%) ⬆️
superset/db_engine_specs/bigquery.py 89.92% <100.00%> (+0.29%) ⬆️
superset/db_engine_specs/gsheets.py 80.00% <100.00%> (+6.66%) ⬆️
superset/db_engine_specs/mysql.py 97.18% <100.00%> (+0.04%) ⬆️
superset/db_engine_specs/postgres.py 97.02% <100.00%> (+0.02%) ⬆️
superset/db_engine_specs/snowflake.py 81.48% <100.00%> (+2.31%) ⬆️
superset/errors.py 100.00% <100.00%> (ø)
superset-frontend/src/utils/urlUtils.ts 45.94% <0.00%> (-7.39%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7f31f...67988e7. Read the comment docs.

@AAfghahi AAfghahi changed the title feat: Big Query and Snowflake SQL Lab errors feat: Better Errors in SQL Lab Jun 29, 2021
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@betodealmeida betodealmeida merged commit 743d9cc into apache:master Jun 29, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* snowflake errors

* added big query

* added to setup error messages, first test

* all big query testing added

* added snowflake test

* added syntax error

* added syntax errors to most used databases
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* snowflake errors

* added big query

* added to setup error messages, first test

* all big query testing added

* added snowflake test

* added syntax error

* added syntax errors to most used databases
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* snowflake errors

* added big query

* added to setup error messages, first test

* all big query testing added

* added snowflake test

* added syntax error

* added syntax errors to most used databases
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants