New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Better Errors in SQL Lab #15432
feat: Better Errors in SQL Lab #15432
Conversation
5376960
to
28832df
Compare
83b350c
to
054c510
Compare
9825f4b
to
9b555bb
Compare
9b555bb
to
ea82bdf
Compare
Codecov Report
@@ Coverage Diff @@
## master #15432 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 974 974
Lines 50701 50773 +72
Branches 6239 6256 +17
=======================================
+ Hits 39126 39182 +56
- Misses 11362 11378 +16
Partials 213 213
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8d8c747
to
67988e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
* snowflake errors * added big query * added to setup error messages, first test * all big query testing added * added snowflake test * added syntax error * added syntax errors to most used databases
* snowflake errors * added big query * added to setup error messages, first test * all big query testing added * added snowflake test * added syntax error * added syntax errors to most used databases
* snowflake errors * added big query * added to setup error messages, first test * all big query testing added * added snowflake test * added syntax error * added syntax errors to most used databases
SUMMARY
Added Syntax, Column, Table, and Schema errors for Big Query and Snowflake. Then updated most often used databases to have syntax errors.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
Big Query:
Postgres:
Syntax Errors:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION