Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more SIP-40 errors to SQL Lab #15436

Merged
merged 1 commit into from Jun 30, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

Add more SIP-40 compatible error responses to SQL Lab.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #15436 (a393acb) into master (ed6d10e) will decrease coverage by 0.00%.
The diff coverage is 60.97%.

❗ Current head a393acb differs from pull request most recent head f1b624a. Consider uploading reports for the commit f1b624a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15436      +/-   ##
==========================================
- Coverage   77.21%   77.21%   -0.01%     
==========================================
  Files         975      975              
  Lines       50662    50664       +2     
  Branches     6228     6228              
==========================================
  Hits        39120    39120              
- Misses      11331    11333       +2     
  Partials      211      211              
Flag Coverage Δ
javascript 71.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)
superset/views/core.py 75.54% <48.14%> (ø)
superset/errors.py 100.00% <100.00%> (ø)
superset/exceptions.py 92.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6d10e...f1b624a. Read the comment docs.

@graceguo-supercat
Copy link

Hi @betodealmeida this PR cause some issues in airbnb: when user hit permission deny error, they will see
Screen Shot 2021-07-08 at 12 33 19 PM

I will revert this PR from airbnb release branch. But it will cause conflict if reverting from master. Could you please take a look?

cc @john-bodley

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants