Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: icon to icons for refreshlabel #15466

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

pkdotson
Copy link
Member

SUMMARY

This pr migrates the icon to icons for the refresh label component within dataset editor.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-06-29 at 3 04 31 PM

TESTING INSTRUCTIONS

Go to dataset editor modal to and view the refreshlabel icon

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #15466 (9724186) into master (4a394cd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15466   +/-   ##
=======================================
  Coverage   77.22%   77.22%           
=======================================
  Files         974      974           
  Lines       50747    50747           
  Branches     6256     6256           
=======================================
  Hits        39187    39187           
  Misses      11347    11347           
  Partials      213      213           
Flag Coverage Δ
javascript 71.78% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Icons/index.tsx 100.00% <ø> (ø)
...set-frontend/src/components/RefreshLabel/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a394cd...9724186. Read the comment docs.

@betodealmeida betodealmeida requested a review from a team June 29, 2021 22:31
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would appreciate a stamp from @michael-s-molina as he has a good grip on this part of the codebase.

@pkdotson pkdotson merged commit ebb3efc into apache:master Jun 30, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants