Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): add new tab when add sql query #15492

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

stephenLYZ
Copy link
Member

SUMMARY

Add new tab when click on +sql query on welcome page.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2021-07-01.4.24.31.mov

after

2021-07-01.4.31.44.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #15492 (341b862) into master (e606477) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 341b862 differs from pull request most recent head 96aa314. Consider uploading reports for the commit 96aa314 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15492   +/-   ##
=======================================
  Coverage   77.20%   77.20%           
=======================================
  Files         975      975           
  Lines       50842    50842           
  Branches     6728     6728           
=======================================
  Hits        39251    39251           
  Misses      11376    11376           
  Partials      215      215           
Flag Coverage Δ
javascript 71.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx 87.17% <ø> (ø)
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 60.60% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e606477...96aa314. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Jul 1, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2021

@rusackas Ephemeral environment spinning up at http://34.216.105.186:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 246368e into apache:master Jul 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2021

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants