Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip set and log when use NullCache #15493

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jul 1, 2021

SUMMARY

skip set cache when use NullCache

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie changed the title fix: skip set and log when NullCache fix: skip set and log when use NullCache Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #15493 (b7b58ef) into master (dd40733) will decrease coverage by 0.04%.
The diff coverage is 64.35%.

❗ Current head b7b58ef differs from pull request most recent head 151a50b. Consider uploading reports for the commit 151a50b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15493      +/-   ##
==========================================
- Coverage   77.11%   77.06%   -0.05%     
==========================================
  Files         974      975       +1     
  Lines       50699    50845     +146     
  Branches     6239     6728     +489     
==========================================
+ Hits        39096    39185      +89     
- Misses      11390    11445      +55     
- Partials      213      215       +2     
Flag Coverage Δ
mysql 81.64% <64.28%> (-0.08%) ⬇️
postgres 81.66% <64.28%> (-0.08%) ⬇️
presto 81.37% <64.28%> (-0.08%) ⬇️
python 81.93% <64.28%> (-0.08%) ⬇️
sqlite 81.28% <64.28%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/components/AnchorLink/index.jsx 95.83% <ø> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/components/Icons/index.tsx 100.00% <ø> (ø)
superset-frontend/src/constants.ts 100.00% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js 1.72% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx 67.15% <ø> (ø)
...dashboard/components/SliceHeaderControls/index.tsx 76.98% <ø> (ø)
...d/src/dashboard/components/gridComponents/Tabs.jsx 88.88% <0.00%> (ø)
...ntend/src/dashboard/containers/DashboardHeader.jsx 100.00% <ø> (ø)
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd40733...151a50b. Read the comment docs.

@amitmiran137 amitmiran137 merged commit 285c1b5 into apache:master Jul 1, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants