fix(native-filters): chartsInScope were not recalculated in some cases

[kgabryje]

SUMMARY

In DashboardContainer we recalculated chartsInScope only when scopes changed. However, when we deleted a filter and added a new one with the same scope, scopes were equal so we didn't calculate chartsInScope for the new filter. That resulted in undefined error. This PR adds filter's ID to scopes so that we sync chartsInScope when scopes change and when new filters are created

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
https://user-images.githubusercontent.com/15073128/124115398-0defa900-da6e-11eb-97c7-1d08df3fd70c.mp4

After:
https://user-images.githubusercontent.com/15073128/124115617-5018ea80-da6e-11eb-97cf-5daeb622cec7.mov

TESTING INSTRUCTIONS

1. Add a native filter
2. Delete that filter and add a new one with the same scope
3. Verify that charts highlighting on filter focus works as expected

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

CC: @villebro

[codecov]

Codecov Report

Merging #15498 (d3daeb4) into master (e5d4765) will increase coverage by 0.04%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master   #15498      +/-   ##
==========================================
+ Coverage   76.97%   77.01%   +0.04%     
==========================================
  Files         975      975              
  Lines       50869    50859      -10     
  Branches     6746     6740       -6     
==========================================
+ Hits        39154    39168      +14     
+ Misses      11500    11475      -25     
- Partials      215      216       +1     

Flag	Coverage Δ
javascript	71.85% <20.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ashboard/components/gridComponents/ChartHolder.jsx	74.73% <ø> (ø)
...components/DashboardBuilder/DashboardContainer.tsx	83.67% <20.00%> (-0.33%)	⬇️
superset-frontend/src/dataMask/actions.ts	42.85% <0.00%> (-35.72%)	⬇️
superset-frontend/src/dataMask/reducer.ts	65.30% <0.00%> (-6.13%)	⬇️
...board/components/nativeFilters/FilterBar/index.tsx	83.17% <0.00%> (-1.09%)	⬇️
...odal/FiltersConfigForm/FilterScope/FilterScope.tsx	91.11% <0.00%> (+2.22%)	⬆️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	73.11% <0.00%> (+2.93%)	⬆️
...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx	93.75% <0.00%> (+3.12%)	⬆️
...mponents/nativeFilters/FiltersConfigModal/utils.ts	75.34% <0.00%> (+5.34%)	⬆️
...nts/controls/DateFilterControl/DateFilterLabel.tsx	66.66% <0.00%> (+8.94%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d4765...d3daeb4. Read the comment docs.