feat(cross-filters): add option to clear set cross filters #15500

villebro · 2021-07-01T12:07:58Z

SUMMARY

This adds the option to clear emitted cross filters by adding an onClick to the cross filter indicator. Also fixes

AFTER

BEFORE

TESTING INSTRUCTIONS

Enable the DASHBOARD_CROSS_FILTERS feature flag
create a chart that supports cross filters and check the "emit cross filters" control
add the chart to a dashboard
emit a cross filter
Hover on the cross filter indicator, see the updated tooltip and click on the indicator to clear emitted filters

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

michael-s-molina · 2021-07-01T12:49:39Z

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true

github-actions · 2021-07-01T12:50:19Z

@michael-s-molina Container image not yet published for this PR. Please try again when build is complete.

github-actions · 2021-07-01T12:50:20Z

@michael-s-molina Ephemeral environment creation failed. Please check the Actions logs for details.

amitmiran137 · 2021-07-01T13:04:13Z

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true

github-actions · 2021-07-01T13:04:58Z

@amitmiran137 Container image not yet published for this PR. Please try again when build is complete.

github-actions · 2021-07-01T13:04:59Z

@amitmiran137 Ephemeral environment creation failed. Please check the Actions logs for details.

codecov · 2021-07-01T13:15:18Z

Codecov Report

Merging #15500 (c4f2752) into master (e606477) will decrease coverage by 0.17%.
The diff coverage is 57.60%.

❗ Current head c4f2752 differs from pull request most recent head 80f13f8. Consider uploading reports for the commit 80f13f8 to get more accurate results

@@            Coverage Diff             @@
##           master   #15500      +/-   ##
==========================================
- Coverage   77.20%   77.03%   -0.18%     
==========================================
  Files         975      976       +1     
  Lines       50842    51247     +405     
  Branches     6728     6897     +169     
==========================================
+ Hits        39251    39476     +225     
- Misses      11376    11552     +176     
- Partials      215      219       +4

Flag	Coverage Δ
javascript	`71.51% <57.00%> (-0.25%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...et-frontend/src/SqlLab/reducers/getInitialState.js	`50.00% <ø> (ø)`
...rset-frontend/src/components/ErrorMessage/types.ts	`100.00% <ø> (ø)`
...ashboard/components/gridComponents/ChartHolder.jsx	`74.73% <ø> (ø)`
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts	`88.88% <0.00%> (ø)`
...mponents/nativeFilters/FiltersConfigModal/utils.ts	`75.34% <ø> (+7.84%)`	⬆️
...filters/components/GroupBy/GroupByFilterPlugin.tsx	`0.00% <0.00%> (ø)`
...ntend/src/filters/components/Range/controlPanel.ts	`100.00% <ø> (ø)`
...RUD/data/database/DatabaseModal/SqlAlchemyForm.tsx	`92.30% <0.00%> (-7.70%)`	⬇️
...set-frontend/src/views/CRUD/data/database/types.ts	`100.00% <ø> (ø)`
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx	`87.17% <ø> (ø)`
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e606477...80f13f8. Read the comment docs.

villebro · 2021-07-01T13:50:13Z

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true

github-actions · 2021-07-01T13:52:18Z

@villebro Ephemeral environment spinning up at http://54.188.176.58:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

michael-s-molina · 2021-07-01T14:29:52Z

@villebro Some suggestions:

Vertical align the emit icon and the filter icon
Make the emit icon and the filter icon the same size (emit is bigger)
I think "Click to clear emitted filter" does not need to be bold because it's secondary information. After the first interaction, the user won't even read that anymore.

michael-s-molina · 2021-07-01T14:34:40Z

superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

+
+export const FilterIndicatorText = styled.div`
+  padding-top: ${({ theme }) => theme.gridUnit * 3}px;
+  font-weight: ${({ theme }) => theme.typography.weights.bold};
+  max-width: 100%;
+  flex-grow: 1;
+  overflow: auto;
+  color: ${({ theme }) => theme.colors.grayscale.light5};
+`;


Suggested change

export const FilterIndicatorText = styled.div`

padding-top: ${({ theme }) => theme.gridUnit * 3}px;

font-weight: ${({ theme }) => theme.typography.weights.bold};

max-width: 100%;

flex-grow: 1;

overflow: auto;

color: ${({ theme }) => theme.colors.grayscale.light5};

`;

export const FilterIndicatorText = styled.div`

${({ theme }) => `

padding-top: ${theme.gridUnit * 3}px;

font-weight: ${theme.typography.weights.bold};

max-width: 100%;

flex-grow: 1;

overflow: auto;

color: ${theme.colors.grayscale.light5};

`}

`;

villebro · 2021-07-02T06:18:42Z

@villebro Some suggestions:

Vertical align the emit icon and the filter icon

Make the emit icon and the filter icon the same size (emit is bigger)

Good catch, I hadn't noticed that.

I think "Click to clear emitted filter" does not need to be bold because it's secondary information. After the first interaction, the user won't even read that anymore.

I agree, will make the change

villebro · 2021-07-02T11:03:08Z

/testenv down

github-actions · 2021-07-02T11:07:07Z

Ephemeral environment shutdown and build artifacts deleted.

villebro · 2021-07-02T11:56:10Z

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true

github-actions · 2021-07-02T11:58:20Z

@villebro Ephemeral environment spinning up at http://35.166.31.72:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

michael-s-molina

LGTM

github-actions · 2021-07-02T14:04:32Z

Ephemeral environment shutdown and build artifacts deleted.

* feat(cross-filters): add option to clear set cross filters * lint * fix indicator size, remove bolded text and rephrase text (cherry picked from commit ee2ee48)

) * feat(cross-filters): add option to clear set cross filters * lint * fix indicator size, remove bolded text and rephrase text

feat(cross-filters): add option to clear set cross filters

f47282b

superset-github-bot bot added the preset-io label Jul 1, 2021

pull-request-size bot added the size/M label Jul 1, 2021

apache deleted a comment from github-actions bot Jul 1, 2021

lint

402dadf

michael-s-molina reviewed Jul 1, 2021

View reviewed changes

amitmiran137 added the v1.3 label Jul 2, 2021

fix indicator size, remove bolded text and rephrase text

80f13f8

villebro requested a review from michael-s-molina July 2, 2021 06:49

villebro closed this Jul 2, 2021

villebro reopened this Jul 2, 2021

michael-s-molina approved these changes Jul 2, 2021

View reviewed changes

amitmiran137 merged commit ee2ee48 into apache:master Jul 2, 2021

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cross-filters): add option to clear set cross filters #15500

feat(cross-filters): add option to clear set cross filters #15500

villebro commented Jul 1, 2021 •

edited

michael-s-molina commented Jul 1, 2021

github-actions bot commented Jul 1, 2021

github-actions bot commented Jul 1, 2021

amitmiran137 commented Jul 1, 2021

github-actions bot commented Jul 1, 2021

github-actions bot commented Jul 1, 2021

codecov bot commented Jul 1, 2021 •

edited

villebro commented Jul 1, 2021

github-actions bot commented Jul 1, 2021

michael-s-molina commented Jul 1, 2021

michael-s-molina Jul 1, 2021

villebro commented Jul 2, 2021

villebro commented Jul 2, 2021

github-actions bot commented Jul 2, 2021

villebro commented Jul 2, 2021

github-actions bot commented Jul 2, 2021

michael-s-molina left a comment

github-actions bot commented Jul 2, 2021

feat(cross-filters): add option to clear set cross filters #15500

feat(cross-filters): add option to clear set cross filters #15500

Conversation

villebro commented Jul 1, 2021 • edited

SUMMARY

AFTER

BEFORE

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

michael-s-molina commented Jul 1, 2021

github-actions bot commented Jul 1, 2021

github-actions bot commented Jul 1, 2021

amitmiran137 commented Jul 1, 2021

github-actions bot commented Jul 1, 2021

github-actions bot commented Jul 1, 2021

codecov bot commented Jul 1, 2021 • edited

Codecov Report

villebro commented Jul 1, 2021

github-actions bot commented Jul 1, 2021

michael-s-molina commented Jul 1, 2021

michael-s-molina Jul 1, 2021

Choose a reason for hiding this comment

villebro commented Jul 2, 2021

villebro commented Jul 2, 2021

github-actions bot commented Jul 2, 2021

villebro commented Jul 2, 2021

github-actions bot commented Jul 2, 2021

michael-s-molina left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 2, 2021

villebro commented Jul 1, 2021 •

edited

codecov bot commented Jul 1, 2021 •

edited