feat: supporting jinja templating in saved metrics #15502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #15502 +/- ##
==========================================
- Coverage 77.20% 76.82% -0.38%
==========================================
Files 975 976 +1
Lines 50842 51306 +464
Branches 6728 6912 +184
==========================================
+ Hits 39251 39417 +166
- Misses 11376 11670 +294
- Partials 215 219 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zhaoyongjie
reviewed
Jul 5, 2021
superset/connectors/sqla/models.py
Outdated
Comment on lines
407
to
414
| def get_template_processor(self, **kwargs: Any) -> BaseTemplateProcessor: | ||
| return self.table.get_template_processor() | ||
|
|
||
| def get_sqla_col(self, label: Optional[str] = None) -> Column: | ||
| label = label or self.metric_name | ||
| sqla_col: ColumnClause = literal_column(self.expression) | ||
| sqla_col: ColumnClause = literal_column( | ||
| self.get_template_processor().process_template(self.expression) | ||
| ) |
There was a problem hiding this comment.
Thanks for your contributions. It is not recommended to add the new instance method(get_template_processor) here.
Suggested change
| def get_template_processor(self, **kwargs: Any) -> BaseTemplateProcessor: | |
| return self.table.get_template_processor() | |
| def get_sqla_col(self, label: Optional[str] = None) -> Column: | |
| label = label or self.metric_name | |
| sqla_col: ColumnClause = literal_column(self.expression) | |
| sqla_col: ColumnClause = literal_column( | |
| self.get_template_processor().process_template(self.expression) | |
| ) | |
| def get_sqla_col(self, label: Optional[str] = None) -> Column: | |
| label = label or self.metric_name | |
| tp = self.table.get_template_processor() | |
| sqla_col = literal_column(tp.process_template(self.expression)) | |
| return self.table.make_sqla_column_compatible(sqla_col, label) |
There was a problem hiding this comment.
Got it,
Fixed the code,
Why it is not recommended to have new instance method? I am asking only yo expand my knowledge
Thanks
There was a problem hiding this comment.
Hi Guy. The main reason is no more self.get_template_processor method call currently, so no need to extend this class. If there is a need for this in the future, we can easily extend it.
|
closes: #6983 |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* feat: supporting jinja templating in saved metrics * cutting the line length to fit requirements * follwing PR I should have not created a new insance method * running precommit locally and fixing the issue Co-authored-by: Guy <guy@nexite.io>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* feat: supporting jinja templating in saved metrics * cutting the line length to fit requirements * follwing PR I should have not created a new insance method * running precommit locally and fixing the issue Co-authored-by: Guy <guy@nexite.io>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* feat: supporting jinja templating in saved metrics * cutting the line length to fit requirements * follwing PR I should have not created a new insance method * running precommit locally and fixing the issue Co-authored-by: Guy <guy@nexite.io>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding the ability to use jinja templating also in saved metrics.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION