Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Utilizing dashboard native filter feature flag #15519

Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

Historically we've seen records in our database where the Dashboard JSON metadata had "show_native_filters": true even though we never enabled the DASHBOARD_NATIVE_FILTERS feature. This was problematic as both native and legacy filters were then present resulting in incorrect behavior when filters were cleared.

It seemed prudent that the default adheres to the feature flag setting rather than being set to true.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #15519 (5c660f0) into master (7889564) will decrease coverage by 0.19%.
The diff coverage is 56.77%.

❗ Current head 5c660f0 differs from pull request most recent head df2569f. Consider uploading reports for the commit df2569f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15519      +/-   ##
==========================================
- Coverage   77.16%   76.97%   -0.20%     
==========================================
  Files         975      976       +1     
  Lines       50865    51218     +353     
  Branches     6740     6894     +154     
==========================================
+ Hits        39251    39426     +175     
- Misses      11398    11573     +175     
- Partials      216      219       +3     
Flag Coverage Δ
javascript 71.52% <55.50%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
...rset-frontend/src/components/InfoTooltip/index.tsx 100.00% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js 1.70% <0.00%> (-0.02%) ⬇️
...RUD/data/database/DatabaseModal/SqlAlchemyForm.tsx 92.30% <0.00%> (-7.70%) ⬇️
...set-frontend/src/views/CRUD/data/database/types.ts 100.00% <ø> (ø)
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx 87.17% <ø> (ø)
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 60.60% <0.00%> (ø)
superset/config.py 97.03% <ø> (ø)
superset/databases/commands/exceptions.py 94.00% <ø> (ø)
superset-frontend/src/views/CRUD/hooks.ts 48.23% <35.00%> (-4.58%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7889564...df2569f. Read the comment docs.

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitmiran137 amitmiran137 merged commit 99fe9c5 into apache:master Jul 2, 2021
amitmiran137 pushed a commit that referenced this pull request Jul 4, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
(cherry picked from commit 99fe9c5)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Co-authored-by: John Bodley <john.bodley@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v1.3 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants