-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Utilizing dashboard native filter feature flag #15519
fix: Utilizing dashboard native filter feature flag #15519
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15519 +/- ##
==========================================
- Coverage 77.16% 76.97% -0.20%
==========================================
Files 975 976 +1
Lines 50865 51218 +353
Branches 6740 6894 +154
==========================================
+ Hits 39251 39426 +175
- Misses 11398 11573 +175
- Partials 216 219 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: John Bodley <john.bodley@airbnb.com> (cherry picked from commit 99fe9c5)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
SUMMARY
Historically we've seen records in our database where the Dashboard JSON metadata had
"show_native_filters": true
even though we never enabled theDASHBOARD_NATIVE_FILTERS
feature. This was problematic as both native and legacy filters were then present resulting in incorrect behavior when filters were cleared.It seemed prudent that the default adheres to the feature flag setting rather than being set to
true
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION