-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: chartlist card-link to 404 #15526
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15526 +/- ##
==========================================
- Coverage 76.97% 76.74% -0.24%
==========================================
Files 976 976
Lines 51251 51260 +9
Branches 6898 6901 +3
==========================================
- Hits 39452 39338 -114
- Misses 11580 11703 +123
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
SUMMARY
/chart/list/undefined
BEFORE ANIMATED GIF
TESTING INSTRUCTIONS
/chart/list/?pageIndex=0&sortColumn=changed_on_delta_humanized&sortOrder=desc&viewMode=card