Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chartlist card-link to 404 #15526

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

xiezhongfu
Copy link
Contributor

SUMMARY

BEFORE ANIMATED GIF

404

TESTING INSTRUCTIONS

  • Go to the chart list view in card mode. eg: /chart/list/?pageIndex=0&sortColumn=changed_on_delta_humanized&sortOrder=desc&viewMode=card
  • Refresh the page
  • While the results are not yet loaded, click on a card
  • before bugfix: See 404 page. after bugfix: no link to 404 page

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #15526 (a38938a) into master (99fe9c5) will decrease coverage by 0.23%.
The diff coverage is 68.42%.

❗ Current head a38938a differs from pull request most recent head 128c4a1. Consider uploading reports for the commit 128c4a1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15526      +/-   ##
==========================================
- Coverage   76.97%   76.74%   -0.24%     
==========================================
  Files         976      976              
  Lines       51251    51260       +9     
  Branches     6898     6901       +3     
==========================================
- Hits        39452    39338     -114     
- Misses      11580    11703     +123     
  Partials      219      219              
Flag Coverage Δ
hive ?
javascript 71.38% <68.42%> (-0.01%) ⬇️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/CRUD/chart/ChartCard.tsx 75.60% <0.00%> (ø)
superset-frontend/src/dataMask/actions.ts 38.88% <33.33%> (-3.97%) ⬇️
...d/src/dashboard/components/FiltersBadge/Styles.tsx 94.87% <50.00%> (-2.43%) ⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx 89.74% <50.00%> (-0.26%) ⬇️
...end/src/dashboard/components/SliceHeader/index.tsx 90.56% <75.00%> (-1.44%) ⬇️
...set-frontend/src/components/ListViewCard/index.tsx 100.00% <100.00%> (ø)
...-frontend/src/components/PopoverDropdown/index.tsx 100.00% <100.00%> (ø)
.../components/FiltersBadge/FilterIndicator/index.tsx 100.00% <100.00%> (ø)
superset-frontend/src/dataMask/reducer.ts 65.30% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99fe9c5...128c4a1. Read the comment docs.

Copy link

@fintzd fintzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@zhaoyongjie zhaoyongjie self-requested a review July 5, 2021 05:52
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@zhaoyongjie zhaoyongjie merged commit b20293d into apache:master Jul 5, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants