Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: icon to icons for nativeFilter components #15528

Merged
merged 5 commits into from
Jul 7, 2021
Merged

refactor: icon to icons for nativeFilter components #15528

merged 5 commits into from
Jul 7, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 2, 2021

SUMMARY

This pr migrates the icons for native filters to the new icons component. The delete icon in the filter config modal and the icons in the cross filter componets.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-07-02 at 7 56 30 AM

TESTING INSTRUCTIONS

Test in the filterconfig modal and the crossfilter propover

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

fintzd
fintzd approved these changes Jul 2, 2021
View reviewed changes
Copy link

@fintzd fintzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@codecov
Copy link

codecov bot commented Jul 2, 2021 •
edited
Loading

Codecov Report

Merging #15528 (d36fd70) into master (7f2f51b) will decrease coverage by 0.29%.
The diff coverage is 54.48%.

❗ Current head d36fd70 differs from pull request most recent head 871275e. Consider uploading reports for the commit 871275e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15528      +/-   ##
==========================================
- Coverage   77.24%   76.95%   -0.30%     
==========================================
  Files         975      976       +1     
  Lines       50866    51289     +423     
  Branches     6740     6907     +167     
==========================================
+ Hits        39293    39468     +175     
- Misses      11357    11602     +245     
- Partials      216      219       +3
Flag Coverage Δ
javascript 71.42% <56.14%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/SqlLab/reducers/getInitialState.js 50.00% <ø> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
superset-frontend/src/dashboard/actions/hydrate.js 1.70% <0.00%> (-0.02%) ⬇️
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 20.83% <0.00%> (-4.17%) ⬇️
...nd/src/dashboard/containers/DashboardComponent.jsx 100.00% <ø> (ø)
...-frontend/src/dashboard/reducers/dashboardState.js 70.96% <0.00%> (-2.37%) ⬇️
...filters/components/GroupBy/GroupByFilterPlugin.tsx 0.00% <0.00%> (ø)
...s/components/TimeColumn/TimeColumnFilterPlugin.tsx 0.00% <0.00%> (ø)
...ers/components/TimeGrain/TimeGrainFilterPlugin.tsx 0.00% <0.00%> (ø)
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2f51b...871275e. Read the comment docs.

@apache apache deleted a comment from github-actions bot Jul 4, 2021
geido
geido reviewed Jul 4, 2021
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor improvements

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTabs.tsx Show resolved Hide resolved
...end/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx Outdated Show resolved Hide resolved
fintzd
fintzd reviewed Jul 5, 2021
View reviewed changes
Copy link

@fintzd fintzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with @geido 's edits

pkdotson and others added 2 commits July 6, 2021 15:22
@pkdotson @geido
Update superset-frontend/src/dashboard/components/nativeFilters/Filte…
72716d3 
…rBar/CascadeFilters/CascadePopover/index.tsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
@pkdotson
add uniform style for icons
8b3a61a
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 6, 2021
@pkdotson pkdotson requested review from suddjian and geido July 6, 2021 23:51
fintzd
fintzd approved these changes Jul 7, 2021
View reviewed changes
Copy link

@fintzd fintzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apache apache deleted a comment from github-actions bot Jul 7, 2021
@pkdotson
Copy link
Member Author

pkdotson commented Jul 7, 2021

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

@pkdotson Ephemeral environment spinning up at http://34.221.155.212:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

geido
geido approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkdotson pkdotson merged commit 58cda8f into apache:master Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@pkdotson @geido
refactor: icon to icons for nativeFilter components (apache#15528)
b264481 
* initial commit for cascade filters

* migrate delete icon

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* add uniform style for icons

* fix lint

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@pkdotson @geido
refactor: icon to icons for nativeFilter components (apache#15528)
5f0e41d 
* initial commit for cascade filters

* migrate delete icon

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* add uniform style for icons

* fix lint

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@pkdotson @geido
refactor: icon to icons for nativeFilter components (apache#15528)
17ee3ad 
* initial commit for cascade filters

* migrate delete icon

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* add uniform style for icons

* fix lint

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fintzd fintzd fintzd approved these changes

@geido geido geido approved these changes

@suddjian suddjian Awaiting requested review from suddjian

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pkdotson @suddjian @fintzd @geido @mistercrunch