-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: examples remove app context at the module level #15546
fix: examples remove app context at the module level #15546
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15546 +/- ##
==========================================
- Coverage 76.96% 76.86% -0.10%
==========================================
Files 976 976
Lines 51305 51319 +14
Branches 6912 6912
==========================================
- Hits 39485 39445 -40
- Misses 11601 11655 +54
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, thanks for cleaning this up!
SUMMARY
Remove bad patterns from the load examples, application context operations at the module level.
Configuration, database operations or other app context operations should execute/evaluate when necessary, while executing a cli operation, a web request a celery task etc, not at module load.
ADDITIONAL INFORMATION