chore: Select component refactoring - ColorSchemeControl - Iteration 5 #15555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/select-component-colorschemecontrol-iteration-5
|
@adam-stasiak @jinghua-qa @junlincc @rosemarie-chiu @rusackas help with testing so much appreciated :) |
Codecov Report
@@ Coverage Diff @@
## master #15555 +/- ##
==========================================
+ Coverage 76.95% 77.12% +0.17%
==========================================
Files 976 976
Lines 51290 51295 +5
Branches 6907 6907
==========================================
+ Hits 39468 39561 +93
+ Misses 11603 11513 -90
- Partials 219 221 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
michael-s-molina
approved these changes
Jul 6, 2021
…onent-colorschemecontrol-iteration-5
|
/testenv up |
|
@rusackas Ephemeral environment spinning up at http://34.213.160.177:8080. Credentials are |
rusackas
approved these changes
Jul 19, 2021
|
Ephemeral environment shutdown and build artifacts deleted. |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
apache#15555) * Enhance Select * Transition Select to Antd * Update test * Fix Cypress * Change name to aria-label * Update Cypress search val * Test Cypress selection
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
apache#15555) * Enhance Select * Transition Select to Antd * Update test * Fix Cypress * Change name to aria-label * Update Cypress search val * Test Cypress selection
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
apache#15555) * Enhance Select * Transition Select to Antd * Update test * Fix Cypress * Change name to aria-label * Update Cypress search val * Test Cypress selection
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It replaces the react-select Select component with the Antdesign one in the ColorSchemeControl component.
BEFORE
ColorSchemeControl-BEFORE.mp4
AFTER
ColorSchemeControl-AFTER.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION