Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #15405 #15435 #15444 #15558

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Jul 6, 2021

SUMMARY

Revert #15405 and PRs that tried to fix it (#15435, #15444).

The change is currently breaking deployments, even after 2 tentative fixes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida changed the title Revert #15405 #15435 #15444 fix: revert #15405 #15435 #15444 Jul 6, 2021
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #15558 (4e70342) into master (314d49c) will decrease coverage by 0.15%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15558      +/-   ##
==========================================
- Coverage   76.86%   76.70%   -0.16%     
==========================================
  Files         976      976              
  Lines       51320    51299      -21     
  Branches     6912     6912              
==========================================
- Hits        39446    39350      -96     
- Misses      11655    11730      +75     
  Partials      219      219              
Flag Coverage Δ
hive ?
mysql 81.54% <33.33%> (-0.01%) ⬇️
postgres 81.56% <33.33%> (-0.01%) ⬇️
python 81.65% <33.33%> (-0.30%) ⬇️
sqlite 81.17% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.15% <28.00%> (-5.89%) ⬇️
superset/app.py 83.33% <100.00%> (+19.84%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.44% <0.00%> (-17.07%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-1.06%) ⬇️
superset/db_engine_specs/base.py 88.14% <0.00%> (-0.40%) ⬇️
superset/connectors/sqla/models.py 88.26% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 88.97% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 314d49c...4e70342. Read the comment docs.

@betodealmeida betodealmeida merged commit 83be06d into apache:master Jul 6, 2021
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Jul 6, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants