-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: icon to icons for sliceheader component #15567
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15567 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 976 976
Lines 51290 51289 -1
Branches 6907 6907
=======================================
Hits 39468 39468
+ Misses 11603 11602 -1
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://52.13.229.102:8080. Credentials are |
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true |
@pkdotson Ephemeral environment spinning up at http://54.189.148.240:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
* initial commit * put back code
* initial commit * put back code
* initial commit * put back code
SUMMARY
mirgrates the filter indicator icon to the icons component
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
![Screen Shot 2021-07-06 at 7 08 45 PM](https://user-images.githubusercontent.com/17326228/124703313-eaca5c80-dea6-11eb-8c4c-a78a3152a561.png)
after
![Screen Shot 2021-07-06 at 9 52 21 PM](https://user-images.githubusercontent.com/17326228/124703291-e1d98b00-dea6-11eb-8a29-ea8c69dc410d.png)
TESTING INSTRUCTIONS
Must enable native filters and crossfiltering feature flags and go to dashboard component
ADDITIONAL INFORMATION