Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: icon to icons for toasts component #15579

Merged
merged 6 commits into from
Jul 9, 2021
Merged

refactor: icon to icons for toasts component #15579

merged 6 commits into from
Jul 9, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 7, 2021

SUMMARY

This component migrates the icons for the toast component to the new icons.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-07-07 at 3 06 05 PM

TESTING INSTRUCTIONS

Manually pulling the branch to hack the toast to present would be the easiest to test as hacking error in ephemereal envior nment is much harder.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 7, 2021 •
edited
Loading

Codecov Report

Merging #15579 (3564a2a) into master (c732d2d) will increase coverage by 0.00%.
The diff coverage is 76.66%.

❗ Current head 3564a2a differs from pull request most recent head b1aba70. Consider uploading reports for the commit b1aba70 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15579   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files         976      976           
  Lines       51293    51325   +32     
  Branches     6907     6910    +3     
=======================================
+ Hits        39471    39497   +26     
- Misses      11603    11609    +6     
  Partials      219      219
Flag Coverage Δ
javascript 71.41% <67.21%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/CRUD/CollectionTable.tsx 78.91% <ø> (ø)
...d/src/dashboard/components/FiltersBadge/Styles.tsx 94.87% <ø> (ø)
...nd/src/dashboard/components/FiltersBadge/index.tsx 86.74% <ø> (-0.16%) ⬇️
.../components/Header/HeaderActionsDropdown/index.jsx 67.50% <ø> (ø)
...re/components/controls/CollectionControl/index.jsx 83.33% <ø> (ø)
...uperset-frontend/src/explore/exploreUtils/index.js 66.45% <0.00%> (ø)
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 76.92% <ø> (ø)
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 72.46% <0.00%> (-2.17%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/styles.ts 82.72% <ø> (ø)
...tend/src/views/CRUD/annotation/AnnotationModal.tsx 60.74% <14.28%> (-2.23%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c732d2d...b1aba70. Read the comment docs.

@pkdotson @suddjian
Update superset-frontend/src/messageToasts/components/Toast.tsx
db64845 
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
@pkdotson pkdotson requested a review from suddjian July 9, 2021 15:18
@michael-s-molina
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

@michael-s-molina Ephemeral environment spinning up at http://18.236.69.172:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

pkdotson and others added 2 commits July 9, 2021 09:46
@pkdotson @michael-s-molina
Update superset-frontend/src/messageToasts/components/Toast.tsx
269b4aa 
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@pkdotson @michael-s-molina
Update superset-frontend/src/messageToasts/components/Toast.tsx
b1aba70 
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@pkdotson pkdotson merged commit 600473f into apache:master Jul 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@pkdotson @suddjian @michael-s-molina
refactor: icon to icons for toasts component (apache#15579)
652d7ab 
* initial commit

* remove code

* fix test

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@pkdotson @suddjian @michael-s-molina
refactor: icon to icons for toasts component (apache#15579)
cf67cfc 
* initial commit

* remove code

* fix test

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@pkdotson @suddjian @michael-s-molina
refactor: icon to icons for toasts component (apache#15579)
ece8062 
* initial commit

* remove code

* fix test

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@suddjian suddjian Awaiting requested review from suddjian

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pkdotson @michael-s-molina @suddjian @mistercrunch