Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: downloadasimage for dashboard #15581

Merged
merged 1 commit into from
Jul 8, 2021
Merged

fix: downloadasimage for dashboard #15581

merged 1 commit into from
Jul 8, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 8, 2021

SUMMARY

This pr fixes the download as image for dashboard.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2021-07-07.at.5.16.12.PM.mov

after

Screen.Recording.2021-07-07.at.4.45.41.PM.mov

closes: #15536

TESTING INSTRUCTIONS

Go to dashboard and click the download as image for the dashboard.

ADDITIONAL INFORMATION

  • [x ] Has associated issue: [dashboard] - Download Image not working #15536
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #15581 (3b616cf) into master (ae160f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15581   +/-   ##
=======================================
  Coverage   76.87%   76.87%           
=======================================
  Files         976      976           
  Lines       51293    51293           
  Branches     6907     6907           
=======================================
  Hits        39431    39431           
  Misses      11643    11643           
  Partials      219      219
Flag Coverage Δ
javascript 71.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/Header/HeaderActionsDropdown/index.jsx 67.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae160f7...3b616cf. Read the comment docs.

@cosmo83
Copy link

cosmo83 commented Jul 8, 2021

Works for me

@michael-s-molina
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

@michael-s-molina Ephemeral environment spinning up at http://54.68.81.124:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina michael-s-molina merged commit 86a59a2 into apache:master Jul 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

Ephemeral environment shutdown and build artifacts deleted.

@junlincc
Copy link
Member

junlincc commented Jul 8, 2021

Thank you @pkdotson and @michael-s-molina for the quick fix and review!

@junlincc junlincc added rush! Requires immediate attention #bug:blocking! Blocking issues with high priority labels Jul 8, 2021
@henryyeh
Copy link
Contributor

henryyeh commented Jul 8, 2021

🏷️ 2021.25

@henryyeh
Copy link
Contributor

henryyeh commented Jul 8, 2021

🏷️ 2021.27

henryyeh pushed a commit to preset-io/superset that referenced this pull request Jul 8, 2021
@pkdotson @henryyeh
initial fix (apache#15581)
bd682ab 
(cherry picked from commit 86a59a2)
@rosemarie-chiu
Copy link
Contributor

Verified this PR in master locally 👍🏻

henryyeh pushed a commit to preset-io/superset that referenced this pull request Jul 8, 2021
@pkdotson @henryyeh
initial fix (apache#15581)
847e3f4 
(cherry picked from commit 86a59a2)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@pkdotson
initial fix (apache#15581)
ceadc0c
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@pkdotson
initial fix (apache#15581)
ae8333b
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@pkdotson
initial fix (apache#15581)
758beea
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

@junlincc junlincc Awaiting requested review from junlincc

@rusackas rusackas Awaiting requested review from rusackas

@suddjian suddjian Awaiting requested review from suddjian

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels #bug:blocking! Blocking issues with high priority preset:2021.25 preset:2021.27 preset-io rush! Requires immediate attention size/XS v1.3 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dashboard] - Download Image not working
8 participants
@pkdotson @cosmo83 @michael-s-molina @junlincc @henryyeh @rosemarie-chiu @mistercrunch @amitmiran137