Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: icon to icons for sqllab #15593

Merged
merged 5 commits into from Jul 12, 2021
Merged

refactor: icon to icons for sqllab #15593

merged 5 commits into from Jul 12, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 8, 2021

SUMMARY

This pr migrates the icons in sqllab editor to the new icons component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Screen Shot 2021-07-08 at 6 29 50 AM
1 SAVE AS
COPY LINK

after
Screen Shot 2021-07-08 at 7 16 05 AM
SAVE AS
2 COPY LINK

TESTING INSTRUCTIONS

Go to sql editor to check out icons

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 9, 2021 •
edited

Codecov Report

Merging #15593 (6b1f613) into master (86a59a2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15593      +/-   ##
==========================================
- Coverage   76.87%   76.85%   -0.02%     
==========================================
  Files         976      976              
  Lines       51292    51313      +21     
  Branches     6907     6920      +13     
==========================================
+ Hits        39430    39437       +7     
- Misses      11643    11653      +10     
- Partials      219      223       +4
Flag Coverage Δ
javascript 71.39% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx 65.11% <100.00%> (+0.83%) ⬆️
...erset-frontend/src/SqlLab/components/SaveQuery.tsx 75.55% <100.00%> (+1.13%) ⬆️
...rontend/src/SqlLab/components/ShareSqlLabQuery.tsx 88.37% <100.00%> (ø)
superset-frontend/src/filters/components/common.ts 90.00% <0.00%> (-10.00%) ⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx 86.66% <0.00%> (-5.65%) ⬇️
...tend/src/views/CRUD/annotation/AnnotationModal.tsx 60.44% <0.00%> (-2.52%) ⬇️
...s/CRUD/data/database/DatabaseModal/ModalHeader.tsx 89.18% <0.00%> (-2.48%) ⬇️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 72.46% <0.00%> (-2.17%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/state.ts 88.88% <0.00%> (-2.03%) ⬇️
...src/filters/components/Range/RangeFilterPlugin.tsx 89.18% <0.00%> (-1.59%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a59a2...6b1f613. Read the comment docs.

@suddjian
Copy link
Member

suddjian commented Jul 9, 2021

Approved with typo corrections

pkdotson and others added 3 commits July 12, 2021 08:24
@pkdotson @suddjian
Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
4b508c9 
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
@pkdotson @michael-s-molina
Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
923806e 
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@pkdotson @suddjian
Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
6b1f613 
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
fintzd
fintzd approved these changes Jul 12, 2021
View reviewed changes
Copy link

@fintzd fintzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's all good, suggested changes were added

@pkdotson pkdotson merged commit d8a15e6 into apache:master Jul 12, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@pkdotson @suddjian @michael-s-molina
refactor: icon to icons for sqllab (apache#15593)
1c0852f 
* initial commit

* rid of theme

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@pkdotson @suddjian @michael-s-molina
refactor: icon to icons for sqllab (apache#15593)
f4c3792 
* initial commit

* rid of theme

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@pkdotson @suddjian @michael-s-molina
refactor: icon to icons for sqllab (apache#15593)
308cdbc 
* initial commit

* rid of theme

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suddjian suddjian suddjian approved these changes

@fintzd fintzd fintzd approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@rusackas rusackas Awaiting requested review from rusackas

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pkdotson @suddjian @fintzd @michael-s-molina @mistercrunch