Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DBC UI tooltip aligment #15595

Merged
merged 2 commits into from
Jul 8, 2021
Merged

fix: DBC UI tooltip aligment #15595

merged 2 commits into from
Jul 8, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 8, 2021

SUMMARY

Fix DB connection UI tooltip alignment, they aren't perfect but much better than before

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-07-08 at 11 32 55 AM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #15595 (2ccde22) into master (301b94f) will not change coverage.
The diff coverage is n/a.

❗ Current head 2ccde22 differs from pull request most recent head 78a69a5. Consider uploading reports for the commit 78a69a5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15595   +/-   ##
=======================================
  Coverage   76.96%   76.96%           
=======================================
  Files         976      976           
  Lines       51318    51318           
  Branches     6907     6907           
=======================================
  Hits        39496    39496           
  Misses      11603    11603           
  Partials      219      219           
Flag Coverage Δ
javascript 71.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 47.86% <ø> (ø)
...c/views/CRUD/data/database/DatabaseModal/styles.ts 82.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301b94f...78a69a5. Read the comment docs.

@hughhhh hughhhh merged commit e539d08 into master Jul 8, 2021
@rosemarie-chiu
Copy link
Contributor

🏷 2021.27

@yousoph
Copy link
Member

yousoph commented Jul 8, 2021

@hughhhh this should be inline with the text

henryyeh pushed a commit to preset-io/superset that referenced this pull request Jul 8, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
@mistercrunch mistercrunch deleted the dbc-ui-tooltips branch March 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.27 size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants