chore: update dataset count badge and tash icon sizing #15608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… text inside via `line-height`
…ext inside via `line-height`, alignedItems inside div w/flex
andrewbastian
changed the title
Codecov Report
@@ Coverage Diff @@
## master #15608 +/- ##
==========================================
- Coverage 76.96% 76.88% -0.08%
==========================================
Files 976 976
Lines 51318 51324 +6
Branches 6907 6907
==========================================
- Hits 39496 39462 -34
- Misses 11603 11643 +40
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AAfghahi
approved these changes
Jul 9, 2021
betodealmeida
approved these changes
Jul 9, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* update trash icon size * changed badge icon `height` to `16px` (using `gridUnits` and centered text inside via `line-height` * changed badge icon `height` to `16px` (using `gridUnits`), centered text inside via `line-height`, alignedItems inside div w/flex
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* update trash icon size * changed badge icon `height` to `16px` (using `gridUnits` and centered text inside via `line-height` * changed badge icon `height` to `16px` (using `gridUnits`), centered text inside via `line-height`, alignedItems inside div w/flex
eschutho
added
the
Superset-Community-Partners
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* update trash icon size * changed badge icon `height` to `16px` (using `gridUnits` and centered text inside via `line-height` * changed badge icon `height` to `16px` (using `gridUnits`), centered text inside via `line-height`, alignedItems inside div w/flex
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Created a
styledComponentto set hight and center numbers on thecount-badgeondataset-tabs. Also added inlinecss={{...align-items:center}}to parent div - centers badge and tab-title.Removed inline
cssfromEditDatasetModals'sIcon.Trash. This Icon now matches the sizing of the otherTrashIconon the datasets homepage(see screenshot).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
CountBadge:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION