Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add waiting time for chart animation when screenshot #15610

Merged
merged 2 commits into from Jul 16, 2021

Conversation

u-aiaa
Copy link
Contributor

@u-aiaa u-aiaa commented Jul 9, 2021

SUMMARY

Since the chart in the report screenshot is sent before the end of the animation
Added a wait time for chart animation when screenshot.

New configuration keys:
SCREENSHOT_SELENIUM_ANIMATION_WAIT: in seconds

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc
Copy link
Member

Thank you so much for your contribution! we will review your proposed solution and code soon

@junlincc
Copy link
Member

change make sense. explained in the original issue.

@junlincc junlincc requested review from dpgaspar and nytai July 15, 2021 00:30
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #15610 (770f67b) into master (2be52c0) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15610      +/-   ##
==========================================
+ Coverage   76.88%   76.96%   +0.08%     
==========================================
  Files         976      977       +1     
  Lines       51320    51419      +99     
  Branches     6907     6907              
==========================================
+ Hits        39458    39577     +119     
+ Misses      11643    11623      -20     
  Partials      219      219              
Flag Coverage Δ
hive 81.28% <100.00%> (-0.01%) ⬇️
mysql 81.54% <100.00%> (-0.02%) ⬇️
postgres 81.56% <100.00%> (-0.02%) ⬇️
presto 81.27% <100.00%> (?)
python 82.10% <100.00%> (+0.14%) ⬆️
sqlite 81.18% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.24% <100.00%> (+0.08%) ⬆️
superset/utils/webdriver.py 79.48% <100.00%> (+0.82%) ⬆️
superset/sql_lab.py 79.92% <0.00%> (-3.56%) ⬇️
superset/utils/core.py 88.25% <0.00%> (-0.84%) ⬇️
superset/views/core.py 75.01% <0.00%> (-0.11%) ⬇️
superset/views/base.py 75.86% <0.00%> (-0.10%) ⬇️
superset/connectors/base/models.py 88.49% <0.00%> (ø)
superset/utils/memoized.py 93.93% <0.00%> (ø)
superset/connectors/druid/models.py 82.81% <0.00%> (+0.01%) ⬆️
superset/databases/api.py 92.95% <0.00%> (+0.02%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be52c0...770f67b. Read the comment docs.

@zhaoyongjie
Copy link
Member

@u-aiaa please fix the pylint CI, Thanks!

@u-aiaa
Copy link
Contributor Author

u-aiaa commented Jul 16, 2021

@zhaoyongjie fixed the pylint.

@nytai nytai merged commit 6b79099 into apache:master Jul 16, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants