New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add waiting time for chart animation when screenshot #15610
Conversation
Thank you so much for your contribution! we will review your proposed solution and code soon |
change make sense. explained in the original issue. |
Codecov Report
@@ Coverage Diff @@
## master #15610 +/- ##
==========================================
+ Coverage 76.88% 76.96% +0.08%
==========================================
Files 976 977 +1
Lines 51320 51419 +99
Branches 6907 6907
==========================================
+ Hits 39458 39577 +119
+ Misses 11643 11623 -20
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@u-aiaa please fix the pylint CI, Thanks! |
@zhaoyongjie fixed the pylint. |
SUMMARY
Since the chart in the report screenshot is sent before the end of the animation
Added a wait time for chart animation when screenshot.
New configuration keys:
SCREENSHOT_SELENIUM_ANIMATION_WAIT: in seconds
ADDITIONAL INFORMATION