fix: duplicate DB names

[betodealmeida]

SUMMARY

Fix the DB name selector by using name as the key, since it's unique. The key we're using, engine, is not unique, since multiple DBs can use the same engine — Apache Spark SQL and Apache Hive both use hive as their engine, eg.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[betodealmeida]

We're setting name instead of database_name somewhere, so I had to add the property here. This is just a quick fix, ideally we should fix the code that sets name and make it set database_name instead.

[codecov]

Codecov Report

Merging #15614 (b48de28) into master (1d572ca) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

❗ Current head b48de28 differs from pull request most recent head 5c7bbcb. Consider uploading reports for the commit 5c7bbcb to get more accurate results

@@            Coverage Diff             @@
##           master   #15614      +/-   ##
==========================================
- Coverage   76.95%   76.87%   -0.09%     
==========================================
  Files         976      976              
  Lines       51324    51324              
  Branches     6910     6910              
==========================================
- Hits        39497    39455      -42     
- Misses      11608    11650      +42     
  Partials      219      219              

Flag	Coverage Δ
javascript	71.40% <50.00%> (-0.02%)	⬇️
presto	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ntend/src/views/CRUD/annotation/AnnotationList.tsx	76.92% <ø> (ø)
...set-frontend/src/views/CRUD/data/database/types.ts	100.00% <ø> (ø)
...tend/src/views/CRUD/annotation/AnnotationModal.tsx	60.74% <14.28%> (-2.23%)	⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx	47.86% <100.00%> (ø)
superset/db_engine_specs/presto.py	84.42% <0.00%> (-5.48%)	⬇️
superset/connectors/sqla/models.py	88.49% <0.00%> (-1.41%)	⬇️
superset/models/core.py	89.76% <0.00%> (-0.27%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d572ca...5c7bbcb. Read the comment docs.

[betodealmeida]

/testenv up

[github-actions]

@betodealmeida Ephemeral environment spinning up at http://52.11.167.57:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[rosemarie-chiu]

🏷 2021.27