Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): expand support for custom branding #15628

Merged
merged 7 commits into from
Jul 14, 2021

Conversation

nytai
Copy link
Member

@nytai nytai commented Jul 10, 2021

SUMMARY

Expands support for custom branding in superset via config options:

  • LOGO_RIGHT_TEXT: text that should appear next to the logo
  • LOGO_TOOLTIP: tooltip that should appear when hovering over logo

Additionally, a watermark Powered by Apache Superset is added if the logo (APP_ICON) is changed from the default superset logo superset-logo-horiz

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
Screen Shot 2021-07-09 at 5 13 56 PM

Screen Shot 2021-07-09 at 5 54 44 PM

TESTING INSTRUCTIONS

  • Manually tested by setting configs

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #15628 (0be57a8) into master (42a1061) will decrease coverage by 0.22%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15628      +/-   ##
==========================================
- Coverage   76.98%   76.75%   -0.23%     
==========================================
  Files         984      984              
  Lines       51702    51721      +19     
  Branches     6977     6981       +4     
==========================================
- Hits        39801    39698     -103     
- Misses      11677    11799     +122     
  Partials      224      224              
Flag Coverage Δ
hive ?
javascript 71.52% <81.25%> (+<0.01%) ⬆️
mysql 81.55% <80.00%> (-0.01%) ⬇️
postgres 81.57% <80.00%> (-0.01%) ⬇️
presto ?
python 81.66% <80.00%> (-0.45%) ⬇️
sqlite 81.19% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/components/Menu/MenuRight.tsx 90.56% <50.00%> (-3.32%) ⬇️
superset/views/base.py 75.86% <66.66%> (-0.10%) ⬇️
superset-frontend/src/components/Menu/Menu.tsx 69.79% <91.66%> (+2.34%) ⬆️
superset/config.py 91.21% <100.00%> (+0.05%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.44% <0.00%> (-17.07%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.95%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.26% <0.00%> (-1.65%) ⬇️
superset/db_engine_specs/base.py 88.28% <0.00%> (-0.40%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a1061...0be57a8. Read the comment docs.

Copy link
Member

@willbarrett willbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green.

@junlincc
Copy link
Member

/testenv up LOGO_RIGHT_TEXT=true LOGO_TOOLTIP=true

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://54.186.213.49:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@nytai nytai merged commit de17acd into apache:master Jul 14, 2021
@nytai nytai deleted the tai/custom-brand-text branch July 14, 2021 16:51
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants