-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(menu): expand support for custom branding #15628
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15628 +/- ##
==========================================
- Coverage 76.98% 76.75% -0.23%
==========================================
Files 984 984
Lines 51702 51721 +19
Branches 6977 6981 +4
==========================================
- Hits 39801 39698 -103
- Misses 11677 11799 +122
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI is green.
/testenv up LOGO_RIGHT_TEXT=true LOGO_TOOLTIP=true |
@junlincc Ephemeral environment spinning up at http://54.186.213.49:8080. Credentials are |
646e59a
to
2d653d5
Compare
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Expands support for custom branding in superset via config options:
Additionally, a watermark
Powered by Apache Superset
is added if the logo (APP_ICON) is changed from the default superset logosuperset-logo-horiz
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
![Screen Shot 2021-07-09 at 5 13 56 PM](https://user-images.githubusercontent.com/10255196/125146175-c908e980-e0e1-11eb-8ff5-116322e49eab.png)
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION