New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show affected charts when interacting with the filters #15634
fix: Show affected charts when interacting with the filters #15634
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15634 +/- ##
==========================================
- Coverage 76.99% 76.95% -0.05%
==========================================
Files 978 984 +6
Lines 51493 51641 +148
Branches 6951 6979 +28
==========================================
+ Hits 39649 39741 +92
- Misses 11620 11676 +56
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true |
@junlincc Ephemeral environment spinning up at http://54.200.139.75:8080. Credentials are |
Click interaction is harder to discover for first time users, but we can just add onboarding steps. |
I'll invert the behavior and activate the affected filters on hover. Maybe with a timer. |
5a3ed3b
to
15a5a51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Shows the affected charts when interacting with the filters in a uniform manner. See before/after videos.
@kgabryje @junlincc @rusackas
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
screen-recording-2021-07-12-at-102722-am_gUCrkkfe.mp4
screen-recording-2021-07-13-at-45541-pm_CQX9Zi5P.mp4
TESTING INSTRUCTIONS
See before/after videos.
ADDITIONAL INFORMATION