Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show affected charts when interacting with the filters #15634

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jul 12, 2021

SUMMARY

Shows the affected charts when interacting with the filters in a uniform manner. See before/after videos.

@kgabryje @junlincc @rusackas

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

screen-recording-2021-07-12-at-102722-am_gUCrkkfe.mp4
screen-recording-2021-07-13-at-45541-pm_CQX9Zi5P.mp4

TESTING INSTRUCTIONS

See before/after videos.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #15634 (15a5a51) into master (f0c0d74) will decrease coverage by 0.04%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15634      +/-   ##
==========================================
- Coverage   76.99%   76.95%   -0.05%     
==========================================
  Files         978      984       +6     
  Lines       51493    51641     +148     
  Branches     6951     6979      +28     
==========================================
+ Hits        39649    39741      +92     
- Misses      11620    11676      +56     
  Partials      224      224              
Flag Coverage Δ
javascript 71.47% <76.47%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/filters/components/Select/SelectFilterPlugin.tsx 79.82% <ø> (ø)
...s/components/TimeColumn/TimeColumnFilterPlugin.tsx 0.00% <ø> (ø)
...ers/components/TimeGrain/TimeGrainFilterPlugin.tsx 0.00% <ø> (ø)
...ts/nativeFilters/FilterBar/FilterControls/utils.ts 71.42% <33.33%> (-28.58%) ⬇️
...veFilters/FilterBar/FilterControls/FilterValue.tsx 67.28% <100.00%> (ø)
...src/filters/components/Range/RangeFilterPlugin.tsx 88.23% <100.00%> (-0.96%) ⬇️
...et-frontend/src/filters/components/Select/index.ts 90.00% <0.00%> (-10.00%) ⬇️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 53.74% <0.00%> (-1.31%) ⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js 34.81% <0.00%> (-0.15%) ⬇️
superset-frontend/src/common/components/index.tsx 100.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c0d74...15a5a51. Read the comment docs.

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Jul 13, 2021
@junlincc junlincc moved this from In progress to In review in Native dashboard filters Jul 13, 2021
@rusackas rusackas requested a review from suddjian July 13, 2021 17:26
@junlincc
Copy link
Member

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://54.200.139.75:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

junlincc commented Jul 13, 2021

Click interaction is harder to discover for first time users, but we can just add onboarding steps.
Your call as long as we have consistency and we dont affect perf. I just need to update the docs :)

@michael-s-molina
Copy link
Member Author

I'll invert the behavior and activate the affected filters on hover. Maybe with a timer.

@michael-s-molina
Copy link
Member Author

@kgabryje @junlincc @rusackas I inverted the behavior. Now the affected charts are displayed on hover. I'm also dispatching the actions using Lodash debounce to avoid unnecessary renders and the blinking effect. I updated the video.

Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit ac01d91 into apache:master Jul 14, 2021
Native dashboard filters automation moved this from In review to Done Jul 14, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/L v1.3 🚢 1.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants