fix: Remove default values for engine and schemas #15635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hughhhh did you test adding/editing a DB with this change? |
Codecov Report
@@ Coverage Diff @@
## master #15635 +/- ##
==========================================
+ Coverage 76.86% 76.98% +0.11%
==========================================
Files 977 979 +2
Lines 51343 51835 +492
Branches 6920 7064 +144
==========================================
+ Hits 39466 39906 +440
- Misses 11654 11702 +48
- Partials 223 227 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
changed the title
|
🏷 2021.27 |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Jul 13, 2021
* remove default values * don't set initial value on save * set defaults for engine_params * update with JSON.parse (cherry picked from commit 2252f33)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* remove default values * don't set initial value on save * set defaults for engine_params * update with JSON.parse
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* remove default values * don't set initial value on save * set defaults for engine_params * update with JSON.parse
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* remove default values * don't set initial value on save * set defaults for engine_params * update with JSON.parse
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove putting a default JSON object whenever engine_params or metadata_params is set. Also removed the allow_schemas_csv_upload quotation marks on that field
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION