Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change sslmode to require for Postgres #15642

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 12, 2021

SUMMARY

Postgres should use sslmode=require for encryption

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hughhhh !

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #15642 (ddee3f3) into master (34542db) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head ddee3f3 differs from pull request most recent head ddf9c0b. Consider uploading reports for the commit ddf9c0b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15642      +/-   ##
==========================================
- Coverage   76.99%   76.76%   -0.23%     
==========================================
  Files         978      978              
  Lines       51486    51486              
  Branches     6950     6950              
==========================================
- Hits        39642    39524     -118     
- Misses      11620    11738     +118     
  Partials      224      224              
Flag Coverage Δ
hive ?
mysql 81.56% <100.00%> (ø)
postgres 81.58% <100.00%> (ø)
presto ?
python 81.67% <100.00%> (-0.45%) ⬇️
sqlite 81.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/postgres.py 97.02% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.44% <0.00%> (-17.07%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.95%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.26% <0.00%> (-1.65%) ⬇️
superset/db_engine_specs/base.py 88.16% <0.00%> (-0.40%) ⬇️
superset/models/core.py 89.79% <0.00%> (-0.27%) ⬇️
superset/utils/core.py 88.77% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34542db...ddf9c0b. Read the comment docs.

@hughhhh hughhhh merged commit f39582c into master Jul 12, 2021
@rosemarie-chiu
Copy link
Contributor

🏷 2021.27

henryyeh pushed a commit to preset-io/superset that referenced this pull request Jul 13, 2021
* change sslmode to require

* fix test

(cherry picked from commit f39582c)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* change sslmode to require

* fix test
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* change sslmode to require

* fix test
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* change sslmode to require

* fix test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
@mistercrunch mistercrunch deleted the hugh/ssl-root-cert branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.27 size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants