Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: icon to icons for navbar #15643

Merged
merged 2 commits into from Jul 13, 2021
Merged

Conversation

pkdotson
Copy link
Member

SUMMARY

This pr changes the triangle down icon to icons in the menu navbar.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Dashboards

after
Dashboards

TESTING INSTRUCTIONS

Test out the navbar in different views Sqllab, listviews and homepage, and explore.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #15643 (b166910) into master (34542db) will increase coverage by 0.00%.
The diff coverage is 88.88%.

❗ Current head b166910 differs from pull request most recent head 94610c1. Consider uploading reports for the commit 94610c1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15643   +/-   ##
=======================================
  Coverage   76.99%   76.99%           
=======================================
  Files         978      978           
  Lines       51486    51488    +2     
  Branches     6950     6951    +1     
=======================================
+ Hits        39642    39644    +2     
  Misses      11620    11620           
  Partials      224      224           
Flag Coverage Δ
javascript 71.52% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Menu/Menu.tsx 67.44% <66.66%> (+0.38%) ⬆️
superset-frontend/src/common/components/index.tsx 100.00% <100.00%> (ø)
...et-frontend/src/components/Menu/LanguagePicker.tsx 100.00% <100.00%> (ø)
...uperset-frontend/src/components/Menu/MenuRight.tsx 93.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34542db...94610c1. Read the comment docs.

@pkdotson
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment creation failed. Please check the Actions logs for details.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.211.173.177:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pkdotson pkdotson merged commit 8efd94a into apache:master Jul 13, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants