Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: icon to icons for IconButton and Header component #15647

Merged
merged 9 commits into from
Jul 14, 2021
Merged

refactor: icon to icons for IconButton and Header component #15647

merged 9 commits into from
Jul 14, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 12, 2021 •
edited
Loading

SUMMARY

This pr refactors the iconbutton component default db icon to the new ant-d dbicon outlined.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
PostgreSQL

after
PostgreSQL

Screen Shot 2021-07-13 at 2 05 27 PM

TESTING INSTRUCTIONS

Test out in databasemodal and dashboard (edit view)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 13, 2021
@pkdotson
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://54.212.110.82:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov
Copy link

codecov bot commented Jul 13, 2021 •
edited
Loading

Codecov Report

Merging #15647 (464d5e6) into master (34542db) will decrease coverage by 0.28%.
The diff coverage is 61.51%.

❗ Current head 464d5e6 differs from pull request most recent head 241c847. Consider uploading reports for the commit 241c847 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15647      +/-   ##
==========================================
- Coverage   76.99%   76.70%   -0.29%     
==========================================
  Files         978      984       +6     
  Lines       51486    51715     +229     
  Branches     6950     6977      +27     
==========================================
+ Hits        39642    39670      +28     
- Misses      11620    11821     +201     
  Partials      224      224
Flag Coverage Δ
javascript 70.96% <52.80%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/reducers/sqlLab.js 34.81% <0.00%> (-0.15%) ⬇️
...-frontend/src/explore/components/controls/index.js 100.00% <ø> (ø)
...s/components/TimeColumn/TimeColumnFilterPlugin.tsx 0.00% <0.00%> (ø)
...ers/components/TimeGrain/TimeGrainFilterPlugin.tsx 0.00% <0.00%> (ø)
...set-frontend/src/views/CRUD/data/database/types.ts 100.00% <ø> (ø)
superset/connectors/base/models.py 88.49% <ø> (ø)
superset/databases/api.py 92.95% <ø> (ø)
superset/views/core.py 75.01% <0.00%> (-0.11%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 47.57% <14.28%> (+0.15%) ⬆️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 53.74% <22.22%> (-1.31%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34542db...241c847. Read the comment docs.

@pkdotson pkdotson changed the title refactor: icon to icons for IconButton component refactor: icon to icons for IconButton and Header component Jul 13, 2021
suddjian
suddjian reviewed Jul 13, 2021
View reviewed changes
superset-frontend/src/components/IconButton/index.tsx Outdated
@@ -41,6 +41,15 @@ const StyledImage = styled.div`
height: ${({ theme }) => theme.gridUnit * 18}px;
margin: ${({ theme }) => theme.gridUnit * 3}px 0;

.default-db-icon {
font-size: ${({ theme }) => theme.gridUnit * 9}px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font sizes shouldn't be set using grid units. There is theme.typography.sizes for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't have a typography size large enough for what you're going for here though. Doing math with the typography sizes sounds pretty unsavory. If we don't want to add an xxxl size maybe grid units are actually the right fit here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yah forgot about that. Maybe i'll just put down the actual font-size then.

suddjian
suddjian approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@suddjian suddjian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm okay with ignoring the sizing semantics issue.

@suddjian
Copy link
Member

Looks like the e2e tests might need some tweaks to select the new icons correctly.

@hughhhh
Copy link
Member

hughhhh commented Jul 14, 2021

@yousoph are okay with the default images for the aria update?

@yousoph
Copy link
Member

yousoph commented Jul 14, 2021

Thumbs up on the db icon 👍

@pkdotson pkdotson merged commit 070f0b6 into apache:master Jul 14, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@pkdotson
refactor: icon to icons for IconButton and Header component (apache#1…
a077947 
…5647)

* initial commit

* fix test

* last one

* fix cypress

* remove gridunit for fonsize

* fix cypress

* more data-test removal

* last one

* more data-test
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@pkdotson
refactor: icon to icons for IconButton and Header component (apache#1…
8387696 
…5647)

* initial commit

* fix test

* last one

* fix cypress

* remove gridunit for fonsize

* fix cypress

* more data-test removal

* last one

* more data-test
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@pkdotson
refactor: icon to icons for IconButton and Header component (apache#1…
41938d3 
…5647)

* initial commit

* fix test

* last one

* fix cypress

* remove gridunit for fonsize

* fix cypress

* more data-test removal

* last one

* more data-test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suddjian suddjian suddjian approved these changes

@hughhhh hughhhh Awaiting requested review from hughhhh

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pkdotson @suddjian @hughhhh @yousoph @mistercrunch