Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small fixes for Makefile #15670

Merged
merged 1 commit into from
Jul 13, 2021
Merged

fix: small fixes for Makefile #15670

merged 1 commit into from
Jul 13, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

2 small fixes for our Makefile:

  1. source venv/bin/activate doesn't work within the Makefile, since source is a shell builtin. I fixed it by doing . venv/bin/activate instead.
  2. Superset only runs on Python 3.7 or 3.8 (some deps fail to install on 3.9). I added a check for the version.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

$ make venv

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Jul 13, 2021
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #15670 (9c66817) into master (351d3c5) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15670      +/-   ##
==========================================
+ Coverage   76.73%   76.75%   +0.01%     
==========================================
  Files         984      984              
  Lines       51713    51702      -11     
  Branches     6978     6977       -1     
==========================================
- Hits        39684    39683       -1     
+ Misses      11805    11795      -10     
  Partials      224      224              
Flag Coverage Δ
javascript 71.51% <ø> (+0.02%) ⬆️
mysql 81.55% <ø> (ø)
postgres 81.57% <ø> (ø)
python 81.66% <ø> (ø)
sqlite 81.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/SqlLab/components/QueryTable/index.jsx 70.31% <0.00%> (+8.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351d3c5...9c66817. Read the comment docs.

@betodealmeida betodealmeida merged commit 42a1061 into master Jul 13, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
@mistercrunch mistercrunch deleted the fix_makefile branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants