Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes unnecessary uses of preselectNativeFilters #15688

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Follow up of #15583 to remove unnecessary uses of preselectNativeFilters.

TESTING INSTRUCTIONS

All tests should pass.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #15688 (0b59be4) into master (b3e699b) will decrease coverage by 0.08%.
The diff coverage is 84.00%.

❗ Current head 0b59be4 differs from pull request most recent head 41966ca. Consider uploading reports for the commit 41966ca to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15688      +/-   ##
==========================================
- Coverage   76.97%   76.89%   -0.09%     
==========================================
  Files         984      984              
  Lines       51713    51722       +9     
  Branches     6977     6976       -1     
==========================================
- Hits        39807    39772      -35     
- Misses      11682    11726      +44     
  Partials      224      224              
Flag Coverage Δ
javascript 71.51% <85.00%> (-0.01%) ⬇️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...veFilters/FilterBar/FilterControls/FilterValue.tsx 66.99% <ø> (-0.30%) ⬇️
...nd/src/dashboard/components/nativeFilters/state.ts 75.00% <ø> (-2.05%) ⬇️
...uperset-frontend/src/components/Menu/MenuRight.tsx 90.56% <50.00%> (-3.32%) ⬇️
superset/views/base.py 75.86% <66.66%> (-0.10%) ⬇️
superset-frontend/src/components/Menu/Menu.tsx 69.79% <91.66%> (+2.34%) ⬆️
...d/components/DashboardBuilder/DashboardBuilder.tsx 90.38% <100.00%> (+0.09%) ⬆️
...src/dashboard/components/DashboardBuilder/state.ts 73.17% <100.00%> (-1.25%) ⬇️
superset/config.py 91.21% <100.00%> (+0.05%) ⬆️
superset/db_engine_specs/presto.py 84.42% <0.00%> (-5.90%) ⬇️
superset/connectors/sqla/models.py 88.49% <0.00%> (-1.41%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e699b...41966ca. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michael-s-molina michael-s-molina merged commit 154f460 into apache:master Jul 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels v1.3 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants