Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better copy for SQL dialog #15714

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

Right now we say "Raw SQL" for the executed SQL:

Screen Shot 2021-07-15 at 10 58 15 AM

I changed the copy to "Executed SQL" after talking to @yousoph, since the term "raw" is confusing and incorrect.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #15714 (d95a099) into master (b489cff) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head d95a099 differs from pull request most recent head 6799d3c. Consider uploading reports for the commit 6799d3c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15714      +/-   ##
==========================================
- Coverage   76.82%   76.82%   -0.01%     
==========================================
  Files         983      983              
  Lines       51585    51586       +1     
  Branches     6974     6974              
==========================================
  Hits        39632    39632              
- Misses      11729    11730       +1     
  Partials      224      224              
Flag Coverage Δ
javascript 71.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/SqlLab/components/HighlightedSql.tsx 90.32% <ø> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 58.97% <0.00%> (ø)
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b489cff...6799d3c. Read the comment docs.

@betodealmeida betodealmeida merged commit d908dd6 into apache:master Jul 15, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants