-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): DndColumnSelect sometimes not working with multi: false #15731
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15731 +/- ##
=======================================
Coverage 76.91% 76.92%
=======================================
Files 983 983
Lines 51602 51609 +7
Branches 6980 6988 +8
=======================================
+ Hits 39688 39698 +10
+ Misses 11691 11688 -3
Partials 223 223
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the fix.
faaac4c
to
48d9596
Compare
/testenv up FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true |
@geido Ephemeral environment spinning up at http://34.220.91.236:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
…apache#15731) * fix(explore): DndColumnSelect not working with multi: false * fix values not synchronized when dataset changes
…apache#15731) * fix(explore): DndColumnSelect not working with multi: false * fix values not synchronized when dataset changes
…apache#15731) * fix(explore): DndColumnSelect not working with multi: false * fix values not synchronized when dataset changes
SUMMARY
Due to incorrect handling of
multi: false
prop inDndColumnSelect
, we sometimes passed an array of arrays of column names, when the chart was expecting an array of column names. Moreover, I noticed that sometimes when we create a chart and then change dataset, chart still tries to use some column names from the old dataset.This PR fixes both issues.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: see #15532
After:
https://user-images.githubusercontent.com/15073128/125910050-317b3f22-8ccd-4a42-b14d-06c01cb38421.mov
TESTING INSTRUCTIONS
ENABLE_EXPLORE_DRAG_AND_DROP
to TrueADDITIONAL INFORMATION
CC: @junlincc