fix: Fixing schemas_allowed_for_upload field in database connection UX
#15750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15750 +/- ##
==========================================
- Coverage 76.92% 76.67% -0.26%
==========================================
Files 983 983
Lines 51609 51612 +3
Branches 6988 6988
==========================================
- Hits 39698 39571 -127
- Misses 11688 11818 +130
Partials 223 223
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
reviewed
Jul 16, 2021
| @@ -393,6 +391,8 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ | |||
| return; | |||
| } | |||
|
|
|||
| console.log(db); | |||
eschutho
reviewed
Jul 16, 2021
| schemas_allowed_for_csv_upload: JSON.stringify( | ||
| extra_json?.schemas_allowed_for_csv_upload, | ||
| ), | ||
| schemas_allowed_for_csv_upload: extra_json?.schemas_allowed_for_csv_upload |
There was a problem hiding this comment.
is this b/c this is rendered as a text field and the others an ace editor?
eschutho
approved these changes
Jul 19, 2021
|
🏷 2021.27 |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Jul 19, 2021
… UX (apache#15750) (cherry picked from commit 7d0f6ab)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixing
schemas_allowed_for_uploadfield in database connection UX by remove an additional JSON stringify before rendering value inside the view.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-07-16.at.5.47.58.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION