Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Reformat Pylint disable checks to multiline #15753

Merged
merged 1 commit into from
Jul 19, 2021
Merged

chore: Reformat Pylint disable checks to multiline #15753

merged 1 commit into from
Jul 19, 2021

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 17, 2021 •
edited
Loading

SUMMARY

Reformatting the Pylint disable checks from one line to one check per line to aid with reviewing for systematically re-enabling checks.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-46] Proposal for strict Pylint enforcement #9953
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie self-requested a review July 18, 2021 18:02
zhaoyongjie
zhaoyongjie approved these changes Jul 18, 2021
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit ca873ac into apache:master Jul 19, 2021
@john-bodley john-bodley deleted the john-bodley--pylintrc branch July 19, 2021 02:11
@john-bodley john-bodley changed the title chore: Reformat disable checks to multiline chore: Reformat Pylint disable checks to multiline Jul 19, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@john-bodley
chore: Reformat disable checks to multiline (apache#15753)
274051f 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@john-bodley
chore: Reformat disable checks to multiline (apache#15753)
70b7901 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@john-bodley
chore: Reformat disable checks to multiline (apache#15753)
7137b89 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

@etr2460 etr2460 Awaiting requested review from etr2460

@graceguo-supercat graceguo-supercat Awaiting requested review from graceguo-supercat

@villebro villebro Awaiting requested review from villebro

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@john-bodley @zhaoyongjie @mistercrunch