fix: Bust chart cache when metric/column is changed #15786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
force-pushed
the
erik-ritter--update-datasource-changed-on
branch
from
0434e5b
to
3ea58d5
Compare
etr2460
force-pushed
the
erik-ritter--update-datasource-changed-on
branch
from
3ea58d5
to
031df18
Compare
|
/testenv up |
|
@etr2460 Ephemeral environment spinning up at http://54.184.252.217:8080. Credentials are |
john-bodley
approved these changes
Jul 21, 2021
|
Ephemeral environment shutdown and build artifacts deleted. |
8 tasks
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Back in #8901 @villebro made changes to include
datasource.changed_onto the chart cache key so that a change to the datasource would bust the chart cache. This was important because a user could change the sql for a datasource, but rerunning the chart wouldn't rerun the query before.In this PR it seems like we intended to also bust the cache when metrics/columns were changed (https://github.com/apache/superset/pull/8901/files#r372541748) but that doesn't seem to work. This PR addresses that oversight and adds a test to check it
TESTING INSTRUCTIONS
CI, new unit test
create a chart, update a metric, see the chart's cache busted
ADDITIONAL INFORMATION
to: @john-bodley @villebro @dpgaspar