New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adds lazy loading and fetchOnlyOnSearch to the Select component #15799
chore: Adds lazy loading and fetchOnlyOnSearch to the Select component #15799
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15799 +/- ##
==========================================
- Coverage 77.13% 77.06% -0.07%
==========================================
Files 984 983 -1
Lines 51704 51650 -54
Branches 6994 6998 +4
==========================================
- Hits 39881 39804 -77
- Misses 11599 11620 +21
- Partials 224 226 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! Just some minor feedback and a question regarding whether we should keep this option open or just make it the standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for answering my questions. LG(reat)TM!
127d795
to
14246ec
Compare
14246ec
to
55666bf
Compare
55666bf
to
04a6afe
Compare
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true |
@michael-s-molina Ephemeral environment spinning up at http://18.236.125.116:8080. Credentials are |
Just waiting for QA approval to merge. @jinghua-qa @junlincc @rosemarie-chiu @adam-stasiak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
screen-recording-2021-07-22-at-21638-pm_feGcoL1I.mp4
Screen.Recording.2021-07-20.at.9.48.11.AM.mov
Screen.Recording.2021-07-20.at.9.46.08.AM.mov
TESTING INSTRUCTIONS
Native filters test:
Storybook test:
fetchOnlyOnSearch
controlADDITIONAL INFORMATION