Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish the new example dashboards #15803

Merged
merged 2 commits into from Jul 22, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

Make sure the new example dashboards are published when we run load-examples.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Run superset load-examples, the new dashboards are now published.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #15803 (b94094d) into master (cbd3780) will decrease coverage by 0.00%.
The diff coverage is 84.61%.

❗ Current head b94094d differs from pull request most recent head 1cf6c45. Consider uploading reports for the commit 1cf6c45 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15803      +/-   ##
==========================================
- Coverage   76.91%   76.90%   -0.01%     
==========================================
  Files         983      984       +1     
  Lines       51643    51698      +55     
  Branches     6991     6991              
==========================================
+ Hits        39720    39758      +38     
- Misses      11699    11716      +17     
  Partials      224      224              
Flag Coverage Δ
mysql 81.53% <90.42%> (-0.02%) ⬇️
postgres 81.55% <90.42%> (-0.02%) ⬇️
python 81.64% <90.42%> (-0.02%) ⬇️
sqlite 81.19% <90.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/explore/actions/saveModalActions.js 61.29% <0.00%> (ø)
superset/commands/importers/v1/examples.py 40.29% <0.00%> (-0.62%) ⬇️
superset/common/query_object.py 90.14% <ø> (ø)
...erset/dashboards/commands/importers/v1/__init__.py 98.50% <ø> (ø)
superset/databases/commands/validate.py 74.57% <ø> (ø)
superset/reports/schemas.py 98.71% <ø> (ø)
superset/utils/mock_data.py 25.18% <ø> (ø)
...nd/src/explore/components/DataTablesPane/index.tsx 83.90% <33.33%> (ø)
superset/charts/api.py 86.17% <81.39%> (-0.63%) ⬇️
...et-frontend/src/components/TableView/TableView.tsx 96.96% <100.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd3780...1cf6c45. Read the comment docs.

@betodealmeida betodealmeida merged commit 2113196 into master Jul 22, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix: publish the new example dashboards

* Fix tests
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix: publish the new example dashboards

* Fix tests
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix: publish the new example dashboards

* Fix tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the publish_examples_dashboards branch March 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants