Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Render value immediately on SQL Editor for Calculated Columns in Edit Dataset modal #15820

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Conversation

geido
Copy link
Member

@geido geido commented Jul 21, 2021

SUMMARY

It renders the typed value immediately to avoid a glitch with the cursor moving backward. It would also avoid delays with rendering the value while typing.

Fixes: #15675
Fixes: #13251

BEFORE

125559494-147c4889-34d4-4e6d-ac76-c64f9d1d1afc

AFTER

DEV.Games.1.mp4

TESTING INSTRUCTIONS

  1. Open a chart in Explore and open the Edit Dataset modal
  2. Click on 'Calculated Columns'
  3. Click on 'Add Item'
  4. Expand the dropdown
  5. Start typing in 'SQL Expression'
  6. Make sure the text is typed immediately and the cursor does not move backward

ADDITIONAL INFORMATION

@geido
Copy link
Member Author

geido commented Jul 21, 2021

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #15820 (f8f89e6) into master (6cb91ee) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15820      +/-   ##
==========================================
- Coverage   77.05%   77.05%   -0.01%     
==========================================
  Files         984      984              
  Lines       51650    51654       +4     
  Branches     6991     6991              
==========================================
+ Hits        39801    39804       +3     
- Misses      11625    11626       +1     
  Partials      224      224              
Flag Coverage Δ
javascript 71.81% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/explore/components/controls/TextAreaControl.jsx 82.35% <83.33%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb91ee...f8f89e6. Read the comment docs.

@geido
Copy link
Member Author

geido commented Jul 21, 2021

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.215.23.49:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Contributor

@rosemarie-chiu rosemarie-chiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA UI test. Yay! Cursor not moving back anymore.

BEFORE:
CleanShot 2021-07-21 at 14 33 09

AFTER:
CleanShot 2021-07-21 at 14 35 02

@junlincc
Copy link
Member

@geido thanks for fixing the issue and spinning up the testenv for the team 🙏

LGTM ✅
After

Screen.Recording.2021-07-21.at.2.34.39.PM.mov

Before

Screen.Recording.2021-07-21.at.2.34.04.PM.mov

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkdotson pkdotson merged commit d4bec13 into apache:master Jul 22, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rosemarie-chiu
Copy link
Contributor

🏷 2021.29

@junlincc junlincc mentioned this pull request Jul 23, 2021
3 tasks
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.29 🚢 1.3.0
Projects
No open projects
5 participants