-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Render value immediately on SQL Editor for Calculated Columns in Edit Dataset modal #15820
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15820 +/- ##
==========================================
- Coverage 77.05% 77.05% -0.01%
==========================================
Files 984 984
Lines 51650 51654 +4
Branches 6991 6991
==========================================
+ Hits 39801 39804 +3
- Misses 11625 11626 +1
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://34.215.23.49:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geido thanks for fixing the issue and spinning up the testenv for the team 🙏 LGTM ✅ Screen.Recording.2021-07-21.at.2.34.39.PM.movBefore Screen.Recording.2021-07-21.at.2.34.04.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
🏷 2021.29 |
SUMMARY
It renders the typed value immediately to avoid a glitch with the cursor moving backward. It would also avoid delays with rendering the value while typing.
Fixes: #15675
Fixes: #13251
BEFORE
AFTER
DEV.Games.1.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION