Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump typescript #15847

Merged
merged 1 commit into from Jul 22, 2021
Merged

Conversation

eschutho
Copy link
Member

SUMMARY

I have a new component in #15790 that is using moment-timezone. Some of the dependencies for that package require a bump in typescript, so I'm isolating the dependencies in separate PRs.
This pr has some new typescript errors that surfaced after bumping the version.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #15847 (6ee1902) into master (04c0680) will decrease coverage by 0.18%.
The diff coverage is 68.08%.

❗ Current head 6ee1902 differs from pull request most recent head 18b0fec. Consider uploading reports for the commit 18b0fec to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15847      +/-   ##
==========================================
- Coverage   77.05%   76.86%   -0.19%     
==========================================
  Files         984      984              
  Lines       51752    51782      +30     
  Branches     7015     7028      +13     
==========================================
- Hits        39875    39804      -71     
- Misses      11653    11753     +100     
- Partials      224      225       +1     
Flag Coverage Δ
hive ?
javascript 71.75% <68.08%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/dashboard/components/Header/index.jsx 66.42% <0.00%> (-0.97%) ⬇️
...nfigModal/FiltersConfigForm/getControlItemsMap.tsx 87.50% <ø> (+1.53%) ⬆️
...set-frontend/src/dashboard/util/injectCustomCss.ts 87.50% <0.00%> (ø)
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 25.00% <50.00%> (+4.16%) ⬆️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 74.34% <61.53%> (+0.58%) ⬆️
superset-frontend/src/components/Select/Select.tsx 72.93% <71.64%> (+0.26%) ⬆️
...rc/explore/components/controls/TextAreaControl.jsx 82.35% <83.33%> (-0.99%) ⬇️
...ersConfigModal/FiltersConfigForm/DatasetSelect.tsx 84.84% <100.00%> (+7.92%) ⬆️
...tend/src/views/CRUD/data/database/DatabaseList.tsx 78.07% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c0680...18b0fec. Read the comment docs.

@eschutho eschutho merged commit 9c854ff into apache:master Jul 22, 2021
@eschutho eschutho deleted the elizabeth/bump-typescript branch July 22, 2021 23:30
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants