feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set #15864

kgabryje · 2021-07-23T11:40:51Z

SUMMARY

If UX_BETA feature flag is set to True, all new datasets will have autocomplete filters enabled by default. The existing datasets will not be modified.
The existing datasets have been set to use autocompleting feature regardless of the feature flag value.
Also, adhoc filters in drag and drop mode have "IN" selected as a if UX_BETA is enabled.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-07-23.at.13.37.34.mov

Screen.Recording.2021-07-26.at.12.32.25.mov

TESTING INSTRUCTIONS

Enable UX_BETA feature flag
Create a new dataset and verify that it has "Autocomplete filters" enabled by default
Create an adhoc filter and verify that after selecting column you can select a value from suggestions. Also, if you're using drag and drop, "IN" operator should be selected by default.

ADDITIONAL INFORMATION

Has associated issue: closes [Upcoming change]Enable Autocomplete filter in Edit Dataset setting by default #15694
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

CC @junlincc @graceguo-supercat

codecov · 2021-07-23T12:04:36Z

Codecov Report

Merging #15864 (d45366d) into master (9c81599) will decrease coverage by 0.24%.
The diff coverage is 35.29%.

❗ Current head d45366d differs from pull request most recent head 07994b6. Consider uploading reports for the commit 07994b6 to get more accurate results

@@            Coverage Diff             @@
##           master   #15864      +/-   ##
==========================================
- Coverage   77.08%   76.84%   -0.25%     
==========================================
  Files         984      984              
  Lines       51788    51801      +13     
  Branches     7037     7038       +1     
==========================================
- Hits        39923    39807     -116     
- Misses      11640    11769     +129     
  Partials      225      225

Flag	Coverage Δ
hive	`?`
javascript	`71.73% <66.66%> (-0.01%)`	⬇️
presto	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx	`65.68% <ø> (ø)`
superset/examples/bart_lines.py	`27.58% <0.00%> (-0.99%)`	⬇️
superset/examples/country_map.py	`25.00% <0.00%> (-0.65%)`	⬇️
superset/examples/energy.py	`26.19% <0.00%> (-0.64%)`	⬇️
superset/examples/flights.py	`17.64% <0.00%> (-0.54%)`	⬇️
superset/examples/long_lat.py	`23.80% <0.00%> (-0.59%)`	⬇️
superset/examples/multiformat_time_series.py	`16.66% <0.00%> (-0.36%)`	⬇️
superset/examples/paris.py	`26.92% <0.00%> (-1.08%)`	⬇️
superset/examples/random_time_series.py	`19.44% <0.00%> (-0.56%)`	⬇️
superset/examples/sf_population_polygons.py	`26.92% <0.00%> (-1.08%)`	⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c81599...07994b6. Read the comment docs.

kgabryje · 2021-07-23T15:20:12Z

/testenv up FEATURE_UX_BETA=true

github-actions · 2021-07-23T15:22:28Z

@kgabryje Ephemeral environment spinning up at http://34.213.99.235:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

kgabryje · 2021-07-23T16:17:28Z

/testenv up FEATURE_UX_BETA=true

github-actions · 2021-07-23T16:21:52Z

@kgabryje Ephemeral environment spinning up at http://54.244.217.223:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

…ETA is set

villebro

LGTM - one minor 🤔 but it shouldn't be blocking as this is behind a FF

villebro · 2021-07-27T12:45:17Z

superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx

+    if (isFeatureEnabled(FeatureFlag.UX_BETA)) {
+      config.operator = OPERATOR_ENUM_TO_OPERATOR_TYPE[Operators.IN].operation;
+      config.operatorId = Operators.IN;
+    }


When we drop a non-string column, the UX feels slightly unintuitive (here I dropped the num column):

Since we have the full set of columns along with their type_generic, maybe we could consider having different behavior for numeric and temporal column types while we're at it?

good idea! it would be great to have the numeric slider in adhoc filter eventually when we redesign the entire component.
For temporal columns, i doubt users would use adhoc filter for it.
For numeric, we can use "=" or "<"? either way, the preselection is not gonna trigger any query, or adding additional clicks to selection, so the change is harmless. it really depends on what our best guess is without further data.

kgabryje · 2021-07-27T15:40:28Z

Ville's comment will be addressed in a follow up PR

github-actions · 2021-07-27T15:40:35Z

Ephemeral environment shutdown and build artifacts deleted.

…ETA is set (apache#15864) * feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set * Lint fix * Set autocomplete to True in example datasets * Use "IN" as a default operator in dnd filters * Default operator only if UX_BETA enabled

kgabryje requested review from ktmud, zhaoyongjie and etr2460 July 23, 2021 11:40

pull-request-size bot added the size/XS label Jul 23, 2021

kgabryje force-pushed the feat/aucomplete-filters branch from 5e0240e to 16d03cd Compare July 23, 2021 11:49

pull-request-size bot added size/M and removed size/XS labels Jul 23, 2021

kgabryje added 3 commits July 26, 2021 11:28

feat(explore): new datasets have autocomplete filters enabled if UX_B…

495c0e0

…ETA is set

Lint fix

9056c59

Set autocomplete to True in example datasets

21a1317

kgabryje force-pushed the feat/aucomplete-filters branch from 405dc35 to 21a1317 Compare July 26, 2021 09:57

kgabryje added 2 commits July 26, 2021 12:32

Use "IN" as a default operator in dnd filters

2510b1c

Default operator only if UX_BETA enabled

07994b6

junlincc requested review from michael-s-molina and villebro and removed request for ktmud and etr2460 July 26, 2021 22:44

villebro approved these changes Jul 27, 2021

View reviewed changes

kgabryje merged commit 3f5237a into apache:master Jul 27, 2021

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set #15864

feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set #15864

kgabryje commented Jul 23, 2021 •

edited

codecov bot commented Jul 23, 2021 •

edited

kgabryje commented Jul 23, 2021

github-actions bot commented Jul 23, 2021

kgabryje commented Jul 23, 2021

github-actions bot commented Jul 23, 2021

villebro left a comment

villebro Jul 27, 2021

junlincc Jul 27, 2021

kgabryje commented Jul 27, 2021 •

edited

github-actions bot commented Jul 27, 2021

feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set #15864

feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set #15864

Conversation

kgabryje commented Jul 23, 2021 • edited

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Jul 23, 2021 • edited

Codecov Report

kgabryje commented Jul 23, 2021

github-actions bot commented Jul 23, 2021

kgabryje commented Jul 23, 2021

github-actions bot commented Jul 23, 2021

villebro left a comment

Choose a reason for hiding this comment

villebro Jul 27, 2021

Choose a reason for hiding this comment

junlincc Jul 27, 2021

Choose a reason for hiding this comment

kgabryje commented Jul 27, 2021 • edited

github-actions bot commented Jul 27, 2021

kgabryje commented Jul 23, 2021 •

edited

codecov bot commented Jul 23, 2021 •

edited

kgabryje commented Jul 27, 2021 •

edited