Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error with Upload Excel form #15867

Closed
wants to merge 1 commit into from
Closed

fix: error with Upload Excel form #15867

wants to merge 1 commit into from

Conversation

aleksandrgordienko
Copy link
Contributor

SUMMARY

Fix error with Upload Excel form

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Create database connection with upload support
  2. Create user with Gamma role + permission for Excel uploading + permission for database
  3. Try to open the Upload Excel form from the menu
  4. If you see the form, the correction fixed error

ADDITIONAL INFORMATION

  • Has associated issue: Error while uploading Excel without all_database_access #15866
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@aleksandrgordienko aleksandrgordienko changed the title Fix error with Upload Excel form fix: error with Upload Excel form Jul 23, 2021
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #15867 (dc57205) into master (9c854ff) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

❗ Current head dc57205 differs from pull request most recent head dd1da62. Consider uploading reports for the commit dd1da62 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15867      +/-   ##
==========================================
- Coverage   77.09%   76.96%   -0.13%     
==========================================
  Files         984      984              
  Lines       51782    51782              
  Branches     7028     7028              
==========================================
- Hits        39920    39853      -67     
- Misses      11637    11704      +67     
  Partials      225      225              
Flag Coverage Δ
hive ?
mysql 81.53% <0.00%> (ø)
postgres 81.55% <0.00%> (ø)
presto 81.29% <0.00%> (+<0.01%) ⬆️
python 81.83% <0.00%> (-0.26%) ⬇️
sqlite 81.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/database/forms.py 88.88% <0.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.44% <0.00%> (-17.07%) ⬇️
superset/connectors/sqla/models.py 89.71% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 88.12% <0.00%> (-0.13%) ⬇️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c854ff...dd1da62. Read the comment docs.

@rusackas
Copy link
Member

Pinging @betodealmeida for review/feedback

@villebro
Copy link
Member

Closing, as this was fixed by #16756

@villebro villebro closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants