fix(15403): Re-enable canceling query for Hive and Presto #15878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Jul 23, 2021
| if cancel_query_id is None: | ||
| return False | ||
|
|
||
| database = query.database | ||
| engine = database.get_sqla_engine( | ||
| engine = query.database.get_sqla_engine( |
There was a problem hiding this comment.
Removing interim variables which likely add unnecessary obfuscation.
Codecov Report
@@ Coverage Diff @@
## master #15878 +/- ##
==========================================
- Coverage 77.08% 77.01% -0.08%
==========================================
Files 984 984
Lines 51787 51797 +10
Branches 7031 7031
==========================================
- Hits 39918 39889 -29
- Misses 11644 11683 +39
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 26, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com> (cherry picked from commit 6d3e19d)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
3 tasks
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Both the Hive and Presto live cursors have implicit async handling to cancel queries, however post #15403 when you stop a query in SQL Lab it incorrectly mentioned that the query could not be stopped and thus prevented to user from iterating within the SQL editor.
This PR adds a new method to check if the database implicitly handles the canceling of queries.
TESTING INSTRUCTIONS
Added unit tests.
ADDITIONAL INFORMATION
cc: @koszti