-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: post-processing for pivot table v2 #15879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
pivot_table_v2
branch
2 times, most recently
from
July 28, 2021 17:49
acd80cb
to
62017fe
Compare
betodealmeida
changed the title
Pivot table v2
feat: post-processing for pivot table v2
Jul 28, 2021
betodealmeida
force-pushed
the
pivot_table_v2
branch
from
July 28, 2021 18:06
62017fe
to
052d850
Compare
betodealmeida
force-pushed
the
pivot_table_v2
branch
from
July 28, 2021 18:12
052d850
to
2b2bca3
Compare
Codecov Report
@@ Coverage Diff @@
## master #15879 +/- ##
==========================================
+ Coverage 76.83% 76.89% +0.05%
==========================================
Files 988 988
Lines 52195 52249 +54
Branches 7095 7095
==========================================
+ Hits 40106 40176 +70
+ Misses 11864 11848 -16
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
approved these changes
Jul 29, 2021
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* feat: add pivot v2 post-processing * Fix lint
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* feat: add pivot v2 post-processing * Fix lint
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* feat: add pivot v2 post-processing * Fix lint
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* feat: add pivot v2 post-processing * Fix lint
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 1.3.0
labels
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds the chart-specific post-processing for the Pivot Table v2, so that text-based reports match the data produced by the visualization.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
I added unit tests for pivot tables v1 and v2. I manually verified that the data produced by the functions match the data produced by the visualization.
ADDITIONAL INFORMATION