Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: post-processing for pivot table v2 #15879

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Jul 23, 2021

SUMMARY

This PR adds the chart-specific post-processing for the Pivot Table v2, so that text-based reports match the data produced by the visualization.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

I added unit tests for pivot tables v1 and v2. I manually verified that the data produced by the functions match the data produced by the visualization.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida force-pushed the pivot_table_v2 branch 2 times, most recently from acd80cb to 62017fe Compare July 28, 2021 17:49
@betodealmeida betodealmeida changed the title Pivot table v2 feat: post-processing for pivot table v2 Jul 28, 2021
@betodealmeida betodealmeida marked this pull request as ready for review July 28, 2021 18:06
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #15879 (dfad33f) into master (3adf8e8) will increase coverage by 0.05%.
The diff coverage is 74.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15879      +/-   ##
==========================================
+ Coverage   76.83%   76.89%   +0.05%     
==========================================
  Files         988      988              
  Lines       52195    52249      +54     
  Branches     7095     7095              
==========================================
+ Hits        40106    40176      +70     
+ Misses      11864    11848      -16     
  Partials      225      225              
Flag Coverage Δ
mysql 81.62% <74.54%> (+0.09%) ⬆️
postgres 81.64% <74.54%> (+0.13%) ⬆️
python 81.73% <74.54%> (+0.09%) ⬆️
sqlite 81.24% <74.54%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/post_processing.py 80.00% <74.54%> (+65.36%) ⬆️
superset/charts/api.py 85.48% <0.00%> (ø)
superset/dashboards/api.py 92.95% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3adf8e8...dfad33f. Read the comment docs.

@betodealmeida betodealmeida merged commit f4739f4 into apache:master Jul 29, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* feat: add pivot v2 post-processing

* Fix lint
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* feat: add pivot v2 post-processing

* Fix lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* feat: add pivot v2 post-processing

* Fix lint
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* feat: add pivot v2 post-processing

* Fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants