Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: New time range filter initially show advance section #15889

Merged
merged 1 commit into from Jul 26, 2021
+5 −1
Merged

fix: New time range filter initially show advance section #15889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...board/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
View file
Open in desktop
Expand Up @@ -585,6 +585,10 @@ const FiltersConfigForm = (

const defaultToFirstItem = formFilter?.controlValues?.defaultToFirstItem;

const hasAdvancedSection =
formFilter?.filterType === 'filter_select' ||
formFilter?.filterType === 'filter_range';

const preFilterValidator = () => {
if (hasTimeRange || hasAdhoc) {
return Promise.resolve();
Expand Down Expand Up @@ -847,7 +851,7 @@ const FiltersConfigForm = (
.filter(key => BASIC_CONTROL_ITEMS.includes(key))
.map(key => controlItems[key].element)}
</Collapse.Panel>
{((hasDataset && hasAdditionalFilters) || hasMetrics) && (
{hasAdvancedSection && (
<Collapse.Panel
forceRender
header={FilterPanels.advanced.name}
Expand Down