-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dashboard url error when edit slug #15893
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15893 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 984 984
Lines 51787 51789 +2
Branches 7036 7038 +2
=======================================
+ Hits 39920 39923 +3
+ Misses 11642 11641 -1
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@junlincc Ephemeral environment spinning up at http://52.10.51.31:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
closes: #15834
Currently, the dashboard list page is unable to update the newest URL when editing the dashboard slug. this PR is fixed this errro.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
URL.did.not.refect.change.right.after.edit.mov
After
compress-edit-slug.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION