Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard url error when edit slug #15893

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

closes: #15834
Currently, the dashboard list page is unable to update the newest URL when editing the dashboard slug. this PR is fixed this errro.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

URL.did.not.refect.change.right.after.edit.mov

After

compress-edit-slug.mp4

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #15893 (bda3ef8) into master (7330aef) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head bda3ef8 differs from pull request most recent head 73bff26. Consider uploading reports for the commit 73bff26 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15893   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files         984      984           
  Lines       51787    51789    +2     
  Branches     7036     7038    +2     
=======================================
+ Hits        39920    39923    +3     
+ Misses      11642    11641    -1     
  Partials      225      225           
Flag Coverage Δ
javascript 71.73% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 71.94% <0.00%> (-0.53%) ⬇️
superset-frontend/src/components/Select/Select.tsx 73.05% <100.00%> (+0.12%) ⬆️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7330aef...73bff26. Read the comment docs.

@junlincc
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://52.10.51.31:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

LGMT, ready for review! @suddjian @pkdotson

@junlincc junlincc requested a review from pkdotson July 26, 2021 22:21
Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@zhaoyongjie zhaoyongjie merged commit 315c52a into apache:master Jul 27, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
4 participants