fix: Keep chosen columns sort option when changing a column #15918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geido
requested review from
pkdotson,
michael-s-molina,
junlincc and
rusackas
and removed request for
pkdotson
Codecov Report
@@ Coverage Diff @@
## master #15918 +/- ##
==========================================
- Coverage 77.01% 76.99% -0.02%
==========================================
Files 986 986
Lines 51978 51983 +5
Branches 7091 7091
==========================================
- Hits 40030 40025 -5
- Misses 11722 11732 +10
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@junlincc Ephemeral environment spinning up at http://52.10.94.110:8080. Credentials are |
junlincc
approved these changes
Jul 28, 2021
|
Ephemeral environment shutdown and build artifacts deleted. |
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…5918) * Keep sorting * Fix adding new column
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…5918) * Keep sorting * Fix adding new column
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…5918) * Keep sorting * Fix adding new column
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…5918) * Keep sorting * Fix adding new column
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR keeps the existing columns sort option while the user makes changes to the columns. Previously the sort order was not kept.
Fixes: #15842
BEFORE
126688420-181454e1-ab8d-4682-bb6e-763005888c1d.mov
AFTER
DEV.Age.distri.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION