fix(dashboard): check dashboard id before calling redux methods #15921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suddjian
force-pushed
the
fix/dashboard-props-checking
branch
from
e7b0ea1
to
8b92971
Compare
Codecov Report
@@ Coverage Diff @@
## master #15921 +/- ##
==========================================
+ Coverage 76.91% 76.98% +0.07%
==========================================
Files 986 986
Lines 51993 51995 +2
Branches 7090 7091 +1
==========================================
+ Hits 39988 40030 +42
+ Misses 11779 11739 -40
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
approved these changes
Jul 28, 2021
|
Thanks for the quick diagnostic and fix! |
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…he#15921) * check dashboard id before calling redux methods * comment
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…he#15921) * check dashboard id before calling redux methods * comment
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…he#15921) * check dashboard id before calling redux methods * comment
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…he#15921) * check dashboard id before calling redux methods * comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes an issue caused by dashboards using
UNSAFE_componentWillReceivePropsto make changes in redux. When switching dashboards via SPA, this check doesn't work. Need to check the dashboard id.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Go to the Birth Names dashboard, then navigate to the World Health dashboard. A warning toast should not pop up.
ADDITIONAL INFORMATION